Allow flashing EC only, update docs on flashing #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`flash.sh` was changed from internally flashing to using the UEFI application (firmware-update). The option `--without-ec` was removed as part of this. Signed-off-by: Tim Crawford <tcrawford@system76.com>
leviport
reviewed
Mar 22, 2024
As somewhat of a hack, allow flashing only the EC by deleting the `firmware.rom` file before running `flash.sh`. Signed-off-by: Tim Crawford <tcrawford@system76.com>
|
Are there any specific behavioural changes I should be looking for on this? It looks like:
I do note that, on a clean pop install and fresh repo clone, running the build script after |
XV-02
reviewed
Apr 16, 2024
XV-02
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
This appears to be working correctly. I could independently flash EC and Firmware, and everything worked as expected.
I could successfully flash with flashrom. But caveat emptor, as we don't have systems which are both supported by flashrom and which have locking firmware that can be unlocked with system76/ec#450 to test that specific functionality overlap.
jackpot51
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As somewhat of a hack, allow flashing only the EC by deleting the
firmware.romfile before runningflash.sh.flash.shwas changed from internally flashing to using the UEFI application (firmware-update). The option--without-ecwas removed as part of this.