Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow controlling debug via config.mk #423

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow controlling debug via config.mk #423

wants to merge 2 commits into from

Conversation

crawfxrd
Copy link
Member

@crawfxrd crawfxrd commented Dec 26, 2023 •
edited

Add new Makefile configs for controlling the log level and mechanisms instead of having to modify the CFLAGS directly.

Allows adding values to top level config.mk instead of the nested common.mk file.

@crawfxrd
Allow setting log level in config file
879b024 
Add a new Makefile config for controlling the log level instead of
having to modify the `LEVEL` cflag directly.

Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd
Add config values to enable debug mechanisms
d61d360 
Add new config values to control whether debug logging is enabled over
parport or smbus instead of having to modify `CFLAGS` directly.

Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd crawfxrd changed the title Allow setting log level in config file Allow controlling debug via config file Dec 28, 2023
@crawfxrd crawfxrd marked this pull request as ready for review December 28, 2023 14:17
@crawfxrd crawfxrd requested review from a team December 28, 2023 14:18
@crawfxrd crawfxrd changed the title Allow controlling debug via config file Allow controlling debug via config.mk Dec 28, 2023
@leviport
Copy link
Member

I'm not seeing a config.mk in the top level. Would a user be expected to generate their own if they want to use this new option?

@crawfxrd
Copy link
Member Author

Yes, the same way that BOARD or KEYMAP can be set. It can also be set in ec.config in firmware-open. This way I can just have a commented out config value and uncomment it when I want to enable logging, such as is done with coreboot and edk2.

@leviport leviport mentioned this pull request Dec 29, 2023
Closed
leviport
leviport approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was tripped up by #424 and had to make USB images from firmware-open, but after that, everything seems to be working nicely with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leviport leviport leviport approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crawfxrd @leviport