Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and use Make targets for deps/setup #402

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add and use Make targets for deps/setup #402

wants to merge 2 commits into from

Conversation

crawfxrd
Copy link
Member

@crawfxrd crawfxrd commented Aug 18, 2023 •
edited

Split the single deps.sh script into logically separate Make targets, including installing Rust in a separate script.

Note:

  • CI works because GitHub runners have a thousand things installed, GNU Make included
  • Submodules also aren't needed for CI as they are not used for building

@crawfxrd
scripts: Split installing Rust to its own script
d4acb79 
Switch the new script from using bash to sh, and set shellcheck to check
against dash.

Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd
Add and use Make targets for deps/setup
3c76c7b 
Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd crawfxrd requested review from a team August 18, 2023 20:02
@XV-02 XV-02 self-assigned this Aug 18, 2023
@XV-02
Copy link

XV-02 commented Aug 18, 2023

Are the CI checks from our github actions sufficient for testing CI functionality?

@crawfxrd
Copy link
Member Author

I'm just saying I'm not bothering to explicitly install make before using Make targets because GitHub runners are guaranteed to have it already.

XV-02
XV-02 approved these changes Aug 18, 2023
View reviewed changes
Copy link

@XV-02 XV-02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, the make targets are working as desired on Pop. Everything installed, and I was able to use EC tooling. I was able to build firmware with dependencies installed using the make target too, so that looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XV-02 XV-02 XV-02 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@XV-02 XV-02

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crawfxrd @XV-02