Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] Added the ability to force RedisCluster #54866

Open
wants to merge 1 commit into
base: 7.2
Choose a base branch
from

Conversation

adideas
Copy link

@adideas adideas commented May 8, 2024

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #...
License MIT

Previously, an array had to be specified to support a cluster. But the nodes can change. Instead of "redis://host-0,redis://host-1" we specify "redis://server?redis_cluster=true"

Previously, an array had to be specified to support a cluster. But the nodes can change. Instead of "redis://host-0,redis://host-1" we specify "redis://server?redis_cluster=true"
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@valtzu
Copy link
Contributor

valtzu commented May 8, 2024

I like it.

Any reason to call the parameter redis_cluster instead of just cluster?

EDIT: ok I guess it's kinda in line with redis_sentinel

@adideas
Copy link
Author

adideas commented May 8, 2024

If you specify a cluster but do not specify it as an array, then a regular redis will start. Then the cluster reports MOVED and everything breaks down.

In the log you can see an error that is most incomprehensible "MOVED ...". You start looking in the documentation and find the redis_cluster parameter in the cache. And then you think why it’s not in "Messenger"

@OskarStark OskarStark changed the title [Messenger] Added the ability to force use RedisCluster in Messenger [Messenger] Added the ability to force RedisCluster May 8, 2024
@xabbuh xabbuh modified the milestones: 7.1, 7.2 May 15, 2024
@adideas
Copy link
Author

adideas commented May 15, 2024

Tell me, did you fix the tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants