[Stopwatch] Add getLastPeriod method to StopwatchEvent
#54855
Merged
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
OskarStark
changed the title
getLastPeriod method to StopwatchEvent
xabbuh
reviewed
May 13, 2024
xabbuh
reviewed
May 13, 2024
|
the new method should also be documented in the changelog file of the Stopwatch component |
hacfi
force-pushed
the
stopwatch-last-period
branch
from
287b821
to
47b86f8
Compare
hacfi
force-pushed
the
stopwatch-last-period
branch
from
47b86f8
to
5c25139
Compare
|
@xabbuh Updated as requested! Anything else left to do? |
xabbuh
approved these changes
May 13, 2024
fabpot
approved these changes
May 21, 2024
|
Thank you @hacfi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's often useful to just get the last period (if you start and stop an event several times).
Example
https://github.com/doctrine/migrations/blob/3.7.x/lib/Doctrine/Migrations/Version/DbalExecutor.php#L167-L168
This adds a simple
getLastPeriodmethod on theStopwatchEventclass.