[DoctrineBridge] fix setting validated fields not using the options array #54835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
May 3, 2024
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 7.1 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
carsonbot
changed the title
wkania
reviewed
May 7, 2024
| @@ -951,6 +951,40 @@ public function rewind(): void | |||
| } | |||
|
|
|||
| public function testValidateDTOUniqueness() | |||
| { | |||
| $constraint = new UniqueEntity( | |||
There was a problem hiding this comment.
The body of those tests is the same, only constraint is different. The dataProvider should be used. This approach is already used in the UniqueEntityValidatorTest::provideConstraintsWithCustomRepositoryMethod.
There was a problem hiding this comment.
I wrote the tests this way on purpose so that we don't have to rewrite them for Symfony 7.2 in #54744
wkania
approved these changes
May 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.