Remove calls to TestCase::iniSet() and calls to deprecated methods of MockBuilder
#54785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
requested review from
chalasr,
xabbuh and
yceruto
as code owners
alexandre-daubois
force-pushed
the
pu-double-deprecs
branch
4 times, most recently
from
62141d7
to
05be1c1
Compare
OskarStark
reviewed
May 2, 2024
src/Symfony/Bridge/Twig/Tests/Extension/HttpKernelExtensionTest.php
Outdated
Show resolved
Hide resolved
alexandre-daubois
force-pushed
the
pu-double-deprecs
branch
from
05be1c1
to
1ee5f6c
Compare
derrabus
requested changes
May 3, 2024
...onent/Form/Tests/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformerTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Console/Tests/Fixtures/MockableAppliationWithTerminalWidth.php
Outdated
Show resolved
Hide resolved
alexandre-daubois
force-pushed
the
pu-double-deprecs
branch
2 times, most recently
from
25bc856
to
7e9804d
Compare
derrabus
reviewed
May 3, 2024
src/Symfony/Component/Routing/Tests/Loader/ObjectLoaderTest.php
Outdated
Show resolved
Hide resolved
alexandre-daubois
force-pushed
the
pu-double-deprecs
branch
3 times, most recently
from
78d0ccf
to
1072546
Compare
derrabus
reviewed
May 3, 2024
src/Symfony/Component/Security/Guard/Tests/GuardAuthenticatorHandlerTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/Tests/Firewall/ContextListenerTest.php
Outdated
Show resolved
Hide resolved
alexandre-daubois
force-pushed
the
pu-double-deprecs
branch
from
1072546
to
01d4f96
Compare
|
No worries, these comments bring elegant code so that's nice to update 😄 |
derrabus
approved these changes
May 3, 2024
alexandre-daubois
force-pushed
the
pu-double-deprecs
branch
from
01d4f96
to
cd182c7
Compare
…of `MockBuilder`
alexandre-daubois
force-pushed
the
pu-double-deprecs
branch
from
cd182c7
to
4d5065d
Compare
xabbuh
approved these changes
May 15, 2024
|
Thank you @alexandre-daubois. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last round (before new deprecations 🙂). All deprecations listed here should be gone.