New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Notifier] [Bluesky] Allow to attach image #54756
Merged
Merged
+169
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
OskarStark
reviewed
Apr 28, 2024
src/Symfony/Component/Notifier/Bridge/Bluesky/Tests/BlueskyTransportTest.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Apr 28, 2024
OskarStark
reviewed
Apr 28, 2024
src/Symfony/Component/Notifier/Bridge/Bluesky/BlueskyTransport.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Apr 28, 2024
jdecool
force-pushed
the
bluesky-media
branch
2 times, most recently
from
April 28, 2024 09:10
50b69d2
to
8ff6d28
Compare
OskarStark
reviewed
Apr 28, 2024
src/Symfony/Component/Notifier/Bridge/Bluesky/BlueskyTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/Bluesky/Tests/BlueskyTransportTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/Bluesky/Tests/BlueskyTransportTest.php
Outdated
Show resolved
Hide resolved
jdecool
force-pushed
the
bluesky-media
branch
4 times, most recently
from
April 28, 2024 09:32
193a7ad
to
43e51aa
Compare
OskarStark
reviewed
Apr 28, 2024
OskarStark
changed the title
[Notifier] Allow to send image to Bluesky
[Notifier][Bluesky] Allow to attach image
Apr 29, 2024
OskarStark
reviewed
Apr 29, 2024
OskarStark
reviewed
May 4, 2024
jdecool
force-pushed
the
bluesky-media
branch
5 times, most recently
from
May 5, 2024 19:32
102f678
to
c0e53c6
Compare
OskarStark
approved these changes
May 6, 2024
carsonbot
changed the title
[Notifier][Bluesky] Allow to attach image
[Notifier] [Bluesky] Allow to attach image
May 6, 2024
Nyholm
reviewed
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely. Well done. Just some minor comments
Nyholm
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
fabpot
approved these changes
May 21, 2024
Thank you @jdecool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to embed an image to a bluesky post.