Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Selenium dependency #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Commits on Nov 19, 2015

  1. Remove Selenium dependency

    The new code uses the (internal) BGG JSON API directly.
    This removes many dependencies, speeds up the process, makes it more
    reliable and makes it possible to handle several copies of a game at
    the same time.
    
    When "collid" is empty or --force-new is given, the importer creates
    new copies of the games. Without --force-new and with non-empty
    "collid" matching existing copies of the games will be updated.
    ssiegel committed Nov 19, 2015
    Configuration menu
    Copy the full SHA
    1f3816e View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2015

  1. Update README to use --force-new for collection migration

    There might be other viable alternatives:
    
      - Create new copies by default, and introduce some --update switch
        to update the existing collection.
    
      - Add a completely new command for updating the collection, like e.g.
        collection-update.
    
      - Detect if the "collid" to be imported is already in the collection.
        Then update if it is, or add a copy if it is not. This solution
        probably exhibits the least surprising behavior for the user, but
        it requires an additional request per imported record or a complete
        export beforehand.
    ssiegel committed Nov 20, 2015
    Configuration menu
    Copy the full SHA
    83db7c0 View commit details
    Browse the repository at this point in the history