Add query flag to insert evt type into payload #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasn
reviewed
Feb 10, 2023
tasn
reviewed
Feb 10, 2023
svix-andor
force-pushed
the
andor/insert-event-type-into-payload
branch
from
30a9f8b
to
3c65795
Compare
svix-gabriel
previously approved these changes
Feb 10, 2023
svix-andor
commented
Feb 10, 2023
svix-andor
force-pushed
the
andor/insert-event-type-into-payload
branch
from
3c65795
to
a2515e3
Compare
svix-andor
force-pushed
the
andor/insert-event-type-into-payload
branch
from
a2515e3
to
a850c80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users use one endpoint to consume different kinds of event types. In these cases it can be useful to have a discriminant in the payload itself to determine the type of event being sent. This PR adds a flag which automates this.
The flag defaults to false (don't insert). If set, it checks if the payload is a JSON object. If not then there's nothing sensible to do. If it is, it checks if there's already a field with the name
"event". If yes, nothing is done. If no, it creates a new field with this name and sets its value to the event type name.