Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

757: Add new options for prefix of whitelabel headers (whitelabel_hea… #759

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

757: Add new options for prefix of whitelabel headers (whitelabel_hea… #759

wants to merge 1 commit into from

Conversation

akash3gupta
Copy link

…ders_prefix)

Motivation

Solution

tasn
tasn requested changes Jan 9, 2023
View reviewed changes
Copy link
Member

@tasn tasn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, though as mentioned in #757, I'm not sure this is something we necessarily want in.

Happy to continue the discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasn tasn tasn requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akash3gupta @tasn