Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add array::shuffle function #3993

Merged
merged 1 commit into from May 15, 2024

Conversation

Odonno
Copy link
Contributor

@Odonno Odonno commented May 7, 2024

Thank you for submitting this pull request! We really appreciate you spending the time to work on these changes.

What is the motivation?

Ability to create a random array from an existing one in a record.

What does this change do?

Add array::shuffle function

What is your testing strategy?

Unit tests

Is this related to any issues?

N/A

Does this change need documentation?

Have you read the Contributing Guidelines?

@Odonno Odonno requested review from a team and tobiemh as code owners May 7, 2024 17:45
tobiemh
tobiemh previously approved these changes May 7, 2024
phughk
phughk previously approved these changes May 13, 2024
Copy link
Contributor

@phughk phughk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thank you @Odonno !

@phughk phughk enabled auto-merge May 13, 2024 16:58
auto-merge was automatically disabled May 13, 2024 18:47

Head branch was pushed to by a user without write access

@Odonno Odonno dismissed stale reviews from phughk and tobiemh via 329d3fc May 13, 2024 18:47
@Odonno Odonno force-pushed the feat/shuffle-array-function branch from 183c67b to 329d3fc Compare May 13, 2024 18:47
@tobiemh tobiemh enabled auto-merge May 15, 2024 08:55
@tobiemh tobiemh added this pull request to the merge queue May 15, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 15, 2024
Merged via the queue into surrealdb:main with commit 97ce910 May 15, 2024
44 checks passed
@Odonno Odonno deleted the feat/shuffle-array-function branch May 15, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants