Remove nom, add recursion limits with arrays. #3975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DelSkayn
force-pushed
the
minor-parser-improvements
branch
from
c45f0c2
to
958bd76
Compare
rushmorem
previously approved these changes
May 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@DelSkayn clippy and tests are failing in the merge queue. Perhaps a new release of Rust? |
maxwellflitton
previously approved these changes
May 8, 2024
|
The clippy warning is indeed due to a new version of rust. The test is |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
DelSkayn
dismissed stale reviews from maxwellflitton, rushmorem, and emmanuel-keller
via
e8a8d16
DelSkayn
force-pushed
the
minor-parser-improvements
branch
from
f5d772d
to
e8a8d16
Compare
phughk
approved these changes
May 13, 2024
tobiemh
approved these changes
May 15, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 15, 2024
Co-authored-by: Tobie Morgan Hitchcock <tobie@surrealdb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request! We really appreciate you spending the time to work on these changes.
What is the motivation? & What does this change do?
This PR fixes a missed recursion limit with arrays.
Also completely removes any remaining usage of nom.
What is your testing strategy?
Added a test for ensuring that the array limit is upheld.
Is this related to any issues?
None
Does this change need documentation?
Have you read the Contributing Guidelines?