Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporary_directory option to StartCommandDbsOptions struct #3867

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Ekwuno
Copy link
Contributor

@Ekwuno Ekwuno commented Apr 12, 2024

Thank you for submitting this pull request! We really appreciate you spending the time to work on these changes.

What is the motivation?

#3749 was added but the option isn't available in the surreal start --help output

What does this change do?

Add CLI output

What is your testing strategy?

Write your test plan here. Please provide us with clear instructions on how you verified your changes work.

Is this related to any issues?

If this pull request is related to other pull requests, or resolves any issues, then link all related or closed items here.

Does this change need documentation?

If this pull request requires changes, updates, or improvements to the documentation, then add a corresponding issue on the docs.surrealdb.com repository, and link to it here.

  • No documentation needed

Have you read the Contributing Guidelines?

@Ekwuno Ekwuno requested a review from a team April 12, 2024 19:26
@tobiemh tobiemh marked this pull request as draft April 19, 2024 19:13
@emmanuel-keller emmanuel-keller marked this pull request as ready for review April 29, 2024 15:14
@emmanuel-keller emmanuel-keller requested review from tobiemh and a team as code owners April 29, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants