Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new spelling #7628

Merged
merged 2 commits into from
May 19, 2024
Merged

new spelling #7628

merged 2 commits into from
May 19, 2024

Conversation

nabobalis
Copy link
Contributor

No description provided.

@nabobalis nabobalis added No Changelog Entry Needed Infrastructure Issues or PRs that affect the CI or packaging of SunPy No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) labels May 15, 2024
ayshih
ayshih reviewed May 15, 2024
View reviewed changes
sunpy/coordinates/spice.py Outdated Show resolved Hide resolved
alasdairwilson
alasdairwilson reviewed May 15, 2024
View reviewed changes
sunpy/conftest.py
yield
del os.environ["PARFIVE_HIDE_PROGESS"]
del os.environ["PARFIVE_HIDE_PROGRESS"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errrrrm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have misspelt this either here for ages or parfive has.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent the following message on Element on 2022-Oct-20:

@Cadair: Um... As far as I can tell, parfive checks the environment variable PARFIVE_HIDE_PROGRESS (https://github.com/Cadair/parfive/blob/c75353cee89715a6eb1bfd9dce704a13cbd0ba52/parfive/config.py#L59), but no external code appears to set the correct environment variable. Instead, they have the misspelled PARFIVE_HIDE_PROGESS (https://github.com/search?q=PARFIVE_HIDE_PROGESS&type=code, and this misspelling is in the parfive docs) or HIDE_PARFIVE_PROGESS (https://github.com/search?q=HIDE_PARFIVE_PROGESS&type=code). Amusingly, sunpy core uses both misspellings.

samaloney
samaloney suggested changes May 15, 2024
View reviewed changes
docs/how_to/create_custom_map.rst Outdated Show resolved Hide resolved
sunpy/coordinates/spice.py Outdated Show resolved Hide resolved
sunpy/net/dataretriever/sources/tests/test_fermi_gbm.py Outdated Show resolved Hide resolved
alasdairwilson
alasdairwilson reviewed May 15, 2024
View reviewed changes
_typos.toml Outdated Show resolved Hide resolved
nabobalis
nabobalis commented May 15, 2024
View reviewed changes
.pre-commit-config.yaml
@@ -1,4 +1,4 @@
exclude: "\\.asdf$"
exclude: ".*(.csv|.fits|.fts|.fit|.header|.txt|tca.*|.json|.asdf)$|^CITATION.rst|tools\/|sunpy\/extern\/|sunpy\/io\/src\/ana\/"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do this, these files we don't care about in general and don't want anything to touch them via the precommit

@nabobalis nabobalis marked this pull request as ready for review May 15, 2024 21:13
@nabobalis nabobalis requested review from a team as code owners May 15, 2024 21:13
@nabobalis nabobalis merged commit 81cccb0 into sunpy:main May 19, 2024
25 of 27 checks passed
@nabobalis nabobalis deleted the spelling branch May 19, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayshih ayshih ayshih left review comments

@alasdairwilson alasdairwilson alasdairwilson left review comments

@samaloney samaloney samaloney requested changes

@wtbarnes wtbarnes wtbarnes approved these changes

Assignees
No one assigned
Labels
Infrastructure Issues or PRs that affect the CI or packaging of SunPy No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) No Changelog Entry Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nabobalis @ayshih @wtbarnes @samaloney @alasdairwilson