Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI a bit more #7618

Merged
merged 6 commits into from
May 11, 2024
Merged

Fix CI a bit more #7618

merged 6 commits into from
May 11, 2024

Conversation

nabobalis
Copy link
Contributor

@nabobalis nabobalis commented May 10, 2024

Patches the two failing tests that I think are not due to flaky issues.

also our doctests?!

@nabobalis nabobalis added Tests Affects tests in some measure No Changelog Entry Needed Infrastructure Issues or PRs that affect the CI or packaging of SunPy No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) Minor Change PR only needs one approval to merge labels May 10, 2024
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@nabobalis nabobalis marked this pull request as ready for review May 11, 2024 01:40
@nabobalis nabobalis requested review from a team as code owners May 11, 2024 01:40
@wtbarnes
Copy link
Member

I don't see any problem here, but why do our Fido doctests change so dramatically?

@nabobalis nabobalis merged commit d61e76e into sunpy:main May 11, 2024
23 of 27 checks passed
@nabobalis nabobalis deleted the ci branch May 11, 2024 05:27
nabobalis added a commit to nabobalis/sunpy that referenced this pull request May 11, 2024
nabobalis added a commit to nabobalis/sunpy that referenced this pull request May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues or PRs that affect the CI or packaging of SunPy Minor Change PR only needs one approval to merge No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) No Changelog Entry Needed Tests Affects tests in some measure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants