-
-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI a bit more #7618
Merged
Merged
Fix CI a bit more #7618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
added
Tests
Affects tests in some measure
No Changelog Entry Needed
Infrastructure
Issues or PRs that affect the CI or packaging of SunPy
No Backport
A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers)
Minor Change
PR only needs one approval to merge
labels
May 10, 2024
nabobalis
commented
May 10, 2024
nabobalis
force-pushed
the
ci
branch
3 times, most recently
from
May 11, 2024 01:07
557f160
to
bc31847
Compare
nabobalis
commented
May 11, 2024
I don't see any problem here, but why do our Fido doctests change so dramatically? |
wtbarnes
approved these changes
May 11, 2024
nabobalis
added a commit
to nabobalis/sunpy
that referenced
this pull request
May 11, 2024
Fix CI a bit more
nabobalis
added a commit
to nabobalis/sunpy
that referenced
this pull request
May 12, 2024
Fix CI a bit more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Infrastructure
Issues or PRs that affect the CI or packaging of SunPy
Minor Change
PR only needs one approval to merge
No Backport
A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers)
No Changelog Entry Needed
Tests
Affects tests in some measure
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches the two failing tests that I think are not due to flaky issues.
also our doctests?!