[map_branch] Moved data methods on mapbase to deprecated mixins #7592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayesla
force-pushed
the
remove_data_methods
branch
from
12f59f9
to
70a1eab
Compare
hayesla
changed the title
hayesla
force-pushed
the
remove_data_methods
branch
from
7ad4d8a
to
244d7be
Compare
2 tasks
bug fix with nans in `test_rotate()`
nabobalis
force-pushed
the
remove_data_methods
branch
5 times, most recently
from
288e632
to
dc44711
Compare
|
Does anyone understand what's triggering these warnings in the doc build? The traceback is not very informative. |
|
And thanks to @nabobalis for fixing this PR. |
nabobalis
force-pushed
the
remove_data_methods
branch
from
dc44711
to
5be6daa
Compare
|
Hopefully those doc fails are now fixed. I amend the last commit with the tweaks. |
DanRyanIrish
approved these changes
Apr 27, 2024
|
Thanks so much @hayesla and @nabobalis. Merging this now! |
DanRyanIrish
merged commit fa61199
into
sunpy:map_ndcube_migration
21 of 27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed following data methods from mapbase and put it in deprecated mixins: