Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redo extra groups and all and add core #7536

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Redo extra groups and all and add core #7536

wants to merge 7 commits into from

Conversation

nabobalis
Copy link
Contributor

@nabobalis nabobalis commented Mar 27, 2024 •
edited

Todo:

  • Add changelog
  • ADd what's new entry
  • add policy to the dev guide on this
  • Fix this from showing
The following packages are not installed for the sunpy[docs-gallery] requirement:
  * astroquery
  * jplephem
  * mplcairo
  • Fix this from being different from the rest
You do not have all the required dependencies installed to run the sunpy test suite.

['hvpy', 'jplephem', 'pytest-astropy', 'pytest-mpl', 'pytest-xdist', 'pytest']

@nabobalis nabobalis added Whats New? Needs a section added to the current Whats New? page. No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) Infrastructure Issues or PRs that affect the CI or packaging of SunPy labels Mar 27, 2024
Cadair
Cadair reviewed Mar 27, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
nabobalis
nabobalis commented Mar 27, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
nabobalis
nabobalis commented Mar 27, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
Cadair
Cadair reviewed Mar 27, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
nabobalis
nabobalis commented Mar 27, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
nabobalis
nabobalis commented Mar 27, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
Cadair
Cadair reviewed Mar 27, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
nabobalis
nabobalis commented Mar 27, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
nabobalis
nabobalis commented Mar 27, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
nabobalis
nabobalis commented Mar 27, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
nabobalis
nabobalis commented Mar 27, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@nabobalis nabobalis added the Run cron CI Run cron CI on this PR label Mar 27, 2024
@nabobalis nabobalis closed this Mar 27, 2024
@nabobalis nabobalis reopened this Mar 27, 2024
@nabobalis nabobalis marked this pull request as ready for review March 28, 2024 23:23
@nabobalis nabobalis requested a review from a team as a code owner March 28, 2024 23:23
@nabobalis nabobalis added the Needs Review Needs reviews before merge label Mar 28, 2024
@nabobalis nabobalis mentioned this pull request Mar 29, 2024
Closed
Cadair
Cadair reviewed Apr 3, 2024
View reviewed changes
tox.ini
extras =
core
commands =
python -c "import sunpy; sunpy.self_test()"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this actually run the test suite? Wouldn't we need the test extra for that?

Maybe this isn't for this PR, but actually I think having things not in the core extra auto-skip in the test suite might not be a bad idea, so we can actually run the tests here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well what do you want to happen?

Do we want to be able to run the test suite with some tests that do not error if only the core deps are installed?

We want them to skip tests, raise a message?

@nabobalis nabobalis added this to the 6.0.0 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cadair Cadair Cadair left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Infrastructure Issues or PRs that affect the CI or packaging of SunPy Needs Review Needs reviews before merge No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) Run cron CI Run cron CI on this PR Whats New? Needs a section added to the current Whats New? page.
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nabobalis @Cadair