fixes the solar_rotate_coordinate()
#7526
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pre-commit.ci autofix |
nabobalis
added
physics
Deus1704
force-pushed
the
solar_rotate_fix
branch
from
80512a9
to
7a502cf
Compare
|
So the figure tests are failing due to some issue with the opencv-python package not being imported correctly. |
|
Yeah the figuredeps are broken due to upstream changes. They can be ignored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR fixes the 2nd issue discussed in #7185.
My reasoning is discussed in this comment
It adds a check in
solar_rotate_coordinate()to ensure the input frame has an "observer" attribute before replicating frame attributes, preventing potential issues with frames lacking this attribute.