Remove the hard dep on parfive #7159
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadair
force-pushed
the
remove_download_sample_Data
branch
from
4df5b2e
to
c6f71ba
Compare
Cadair
commented
Aug 17, 2023
| @@ -42,6 +40,8 @@ class ParfiveDownloader(DownloaderBase): | |||
| """ | |||
|
|
|||
| def download(self, url, path): | |||
| from sunpy.util.parfive_helpers import Downloader | |||
There was a problem hiding this comment.
This is basically a hack. We need to be able to import sunpy.data for our tests, but the user API requires parfive. I am open to better suggestions.
Cadair
commented
Aug 17, 2023
nabobalis
reviewed
Aug 21, 2023
ayshih
changed the title
download_sample_data()
wtbarnes
force-pushed
the
remove_download_sample_Data
branch
from
bfd91bc
to
53cf25a
Compare
dstansby
requested changes
Oct 16, 2023
nabobalis
force-pushed
the
remove_download_sample_Data
branch
from
a404149
to
402ecc2
Compare
nabobalis
changed the title
download_sample_data()
nabobalis
added
net
This comment was marked as outdated.
This comment was marked as outdated.
nabobalis
force-pushed
the
remove_download_sample_Data
branch
2 times, most recently
from
a826b7c
to
4fbd20b
Compare
nabobalis
force-pushed
the
remove_download_sample_Data
branch
from
4fbd20b
to
f8feaae
Compare
|
I made this PR a mess, i'll fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We deprecated it already, this should practically fix #7150 but I think we need to add some testing infra before we close that.