Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding example gallery + minor refactor of the doc layout #113

Merged
merged 7 commits into from
May 22, 2024

Conversation

hayesla
Copy link
Member

@hayesla hayesla commented Jan 24, 2024

This draft PR is to add an example gallery to the docs

Fixes #103

@nabobalis I may need your help with the sphinx stuff 🤷‍♀️

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aab7771) 94.64% compared to head (76a1b18) 94.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files           6        6           
  Lines         280      280           
=======================================
  Hits          265      265           
  Misses         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dstansby
Copy link
Member

Looks like you're missing sphinx-gallery from the extensions in conf.py too: https://sphinx-gallery.github.io/stable/getting_started.html#configure-and-use-sphinx-gallery

@hayesla
Copy link
Member Author

hayesla commented Jan 24, 2024

thanks @dstansby - looks like thats working now

setup.cfg Outdated Show resolved Hide resolved
@nabobalis nabobalis changed the title Adding example gallery Adding example gallery + minor refactor of the doc layout May 22, 2024
@nabobalis nabobalis force-pushed the adding_example_gallery branch 5 times, most recently from 2d43252 to d95e2a9 Compare May 22, 2024 20:50
@nabobalis nabobalis merged commit 11334f2 into sunpy:main May 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an example gallery
4 participants