Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New image alignment function #82

Open
Richardjmorton opened this issue Jan 12, 2021 · 3 comments
Open

New image alignment function #82

Richardjmorton opened this issue Jan 12, 2021 · 3 comments

Comments

@Richardjmorton
Copy link

I would like to add to the suite of alignment routines that sunpy offers, bringing in a function that will align data based on series of temporally local image frames. This leads to more robust alignment of image sequences, especially if there is large changes in the scene over the sequence.

I brought this up in the google group a while back.

I have this implemented in python, but would be willing to re-write to fit in with the sunpy style.

This is may first attempt at submitting to a project like this, so would appreciate some guidance on how to contribute.

Description

@nabobalis
Copy link
Contributor

Hi Rick,

To start off, I think we can keep it simple. If you can fork the sunpy repository and add the code to either an existing file (coalignment.py maybe?) or new file under this location: https://github.com/sunpy/sunpy/tree/master/sunpy/image file.
You can commit that and open the pull request and we can go from there.

The sunpy style is a simple script that checks for basic python PEP8 issues, otherwise it will need a test but that is all we can work on the pull request.

If you need any thing else, please don't hesitate to ask here!

@Richardjmorton
Copy link
Author

Thanks Nabil! Let's see how it goes.

@dstansby
Copy link
Member

@nabobalis could you move this issue over to the sunkit-image repository?

@nabobalis nabobalis transferred this issue from sunpy/sunpy Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants