Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the coalignment module #83

Open
wtbarnes opened this issue Mar 24, 2022 · 0 comments
Open

Refactor the coalignment module #83

wtbarnes opened this issue Mar 24, 2022 · 0 comments

Comments

@wtbarnes
Copy link
Member

wtbarnes commented Mar 24, 2022

The coalignment module now includes code from sunpy.image.coalignment as well as sunpy.physics.solar_rotation. Both of these bits of code provide methods for co-aligning images, but the API is a bit all over the place at the moment. We need to decide how we want users to interact with this code (e.g. do we want one mapsequence_coalign function with different keywords to select how the coalignment is done?) and refactor things to remove duplicate code.

We should also think about how we want to then incorporate new coalignment functions (e.g. #82).

This should probably be worked out prior to #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant