Remove Genesis G90 from 255 STEER_MAX list. #309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The g90 fingerprint was merged into openpilot via:
commaai/openpilot#31893
Not sure if this is the right place to send this PR, if it's not. I can re-do provided the correct branch.
Description
A description of the bug and the fix. Also link the issue if it exists.
G90 steering torque is weak. Validated that it could handle > 255 steering torques.
removed G90 from 255 STEER_MAX list.
Verification
Explain how you tested this bug fix.
Forked and have been running for a week.
Route
Routes:
12143ca5b941c412|2024-03-24--12-15-12
12143ca5b941c412/2024-03-23--17-32-46
12143ca5b941c412/2024-03-22--19-28-56