Prevent Gtk-CRITICAL warning when removing toolbar item #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: When windows size gets decreased to a specific point and then increase again the following warning occurs, `Gtk-CRITICAL **: 13:29:23.501: gtk_toolbar_remove: assertion 'content_to_remove != NULL' failed` Change: Added a safety check to ensure that `self._coordinates_toolitem` is in `self._view_toolbar` before attempting to remove it.
|
I'm not able to reproduce the issue, can you share how to? |
|
Sure, open the activity on 1680x1050 resolution and go down to 640x480 resolution and then go up again to 1680x1050 resolution. The resolution numbers don't have to be exact, those are just what I mostly used for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When windows size gets decreased to a specific point and then increase again the following warning occurs,
Gtk-CRITICAL **: 13:29:23.501: gtk_toolbar_remove: assertion 'content_to_remove != NULL' failedChange: Added a safety check to ensure that
self._coordinates_toolitemis inself._view_toolbarbefore attempting to remove it.