Created darkmode button and JS implementation according to Issue #383… #3876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rlabs#3838 and updated Tone.js to use AudioWorklet Node according to Issue sugarlabs#3555
|
The background color is defined in js/utils/platformstyle.js Probably you can do most of the work for dark mode by modifying that file. I am a but wary of maintaining a fork of tone.js. Might make more sense to work upstream on that one. |
|
Also, please create separate MRs for dark mode and AudioWorklet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…8 and updated Tone.js to use AudioWorklet Node according to Issue #3555
Hi, I have been working with my colleague to complete these two tasks as part of a school project. We are both university students taking a software engineering course.
The changes we have implemented are not complete but do offer some functionality.
We created a darkmode button in index.html, mimicking the toolbar design to the best of our abilities but the styling is still a bit off. We implemented the JS code in both toolbar.js and activity.js again mimicking the patterns to the best of our ability.
We ran into an issue with the Turtles.js library because it is used to create a canvas that acts as an overlay on the website. We weren't able to figure out where we could access its background color within activity.js.
So far, the darkmode button works but only if you minimize the canvas using the collapse button in the top right below the toolbar.
Finally, we updated Tone.js to use AudioWorkletNode by finding the most recent version released by the library creators. However, they still use ScriptProcessorNode in some spots. Perhaps in the future they will completely migrate to AudioWorkletNode.
Thank you for reading!