Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added musical example of double sharps and flats #3855 #3872

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

byoojh
Copy link

@byoojh byoojh commented Apr 21, 2024

Added a section in the guide under the sharps and flat to describe use cases of double sharps and flats, along with some well known musical examples.

@pikurasa pikurasa self-requested a review April 22, 2024 19:55
@pikurasa
Copy link
Collaborator

I'm assuming this is ready for review, so I'm checking it out.

@pikurasa
Copy link
Collaborator

It's going well so far. Two comments:

  1. Accidentals

In addition to using the "accidental override", I think you should add examples of selecting those accidentals from the pie menu as follows:

Screenshot from 2024-04-22 16-00-19
Screenshot from 2024-04-22 16-01-18
Screenshot from 2024-04-22 16-01-32

  1. Left/right

In the text, it refers to examples on the left and right. However, they display for me above and below. Perhaps just refer to them as first and second example, or, if you can, add captions underneath and refer to them as "the example by Liszt" and "the example by Bartok".

Screenshot from 2024-04-22 16-02-37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants