New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation in protoblocks.js #3830
base: master
Are you sure you want to change the base?
Conversation
js/protoblocks.js
Outdated
@@ -527,6 +632,9 @@ class ProtoBlock { | |||
} | |||
// E.g., distance . Distance block will calculate geometrical distance between two pointa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this "e.g." belongs in the comment block below (L636)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the rectification walter. I'll correct it and get back to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had made the necessary changes. Let me know if it's up to Mark or not.
js/protoblocks.js
Outdated
@@ -222,6 +263,10 @@ class ProtoBlock { | |||
} | |||
|
|||
// E.g., forward, right |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should delete this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@walterbender Shifted all the respective comments mentioned by you. Thank you for showing me the ropes.
js/protoblocks.js
Outdated
@@ -252,6 +301,9 @@ class ProtoBlock { | |||
} | |||
|
|||
// E.g., wait for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line should move into the description below.
js/protoblocks.js
Outdated
@@ -284,6 +340,9 @@ class ProtoBlock { | |||
} | |||
|
|||
// E.g., setxy. These are expandable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this one.
js/protoblocks.js
Outdated
@@ -325,6 +389,9 @@ class ProtoBlock { | |||
} | |||
|
|||
// E.g., ??? These are expandable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one can stay.
js/protoblocks.js
Outdated
@@ -409,6 +490,10 @@ class ProtoBlock { | |||
} | |||
|
|||
// E.g., sqrt, box |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this one...
js/protoblocks.js
Outdated
@@ -442,6 +531,10 @@ class ProtoBlock { | |||
} | |||
|
|||
// E.g., plus, minus, multiply, divide, power,distance. These are also expandable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this one
js/protoblocks.js
Outdated
@@ -572,6 +686,9 @@ class ProtoBlock { | |||
|
|||
// E.g., number, string. Value blocks get DOM textareas associated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should move
js/protoblocks.js
Outdated
@@ -633,6 +759,11 @@ class ProtoBlock { | |||
|
|||
// E.g., start. A "child" flow is docked in an expandable clamp. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these should move
js/protoblocks.js
Outdated
@@ -672,6 +808,9 @@ class ProtoBlock { | |||
} | |||
|
|||
// E.g., emptyclamp. Unlike start, there is a flow above and below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this one
js/protoblocks.js
Outdated
@@ -711,6 +855,9 @@ class ProtoBlock { | |||
} | |||
|
|||
// E.g., repeat. Unlike action, there is a flow above and below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this one...
js/protoblocks.js
Outdated
@@ -753,6 +905,9 @@ class ProtoBlock { | |||
|
|||
// E.g., tuplet, which takes two args plus an interior flow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this one
js/protoblocks.js
Outdated
@@ -753,6 +905,9 @@ class ProtoBlock { | |||
|
|||
// E.g., tuplet, which takes two args plus an interior flow. | |||
// There is a flow above and below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this one
js/protoblocks.js
Outdated
@@ -835,6 +1003,9 @@ class ProtoBlock { | |||
} | |||
|
|||
// E.g., do with args: innies instead of interior slots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this one
js/protoblocks.js
Outdated
@@ -877,6 +1053,9 @@ class ProtoBlock { | |||
} | |||
|
|||
// E.g., calculate with args: innies instead of interior slots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one
js/protoblocks.js
Outdated
@@ -919,6 +1103,9 @@ class ProtoBlock { | |||
} | |||
|
|||
// E.g., named do with args: innies instead of interior slots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this one
js/protoblocks.js
Outdated
@@ -956,6 +1148,9 @@ class ProtoBlock { | |||
} | |||
|
|||
// E.g., named calculate with args: innies instead of interior slots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this one
js/protoblocks.js
Outdated
@@ -995,6 +1195,9 @@ class ProtoBlock { | |||
|
|||
// E.g., if. A "child" flow is docked in an expandable clamp. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this one
js/protoblocks.js
Outdated
@@ -1037,6 +1245,10 @@ class ProtoBlock { | |||
// E.g., if then else. Two "child" flows are docked in expandable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this one
js/protoblocks.js
Outdated
@@ -1086,6 +1304,10 @@ class ProtoBlock { | |||
} | |||
|
|||
// E.g., forever. Unlike start, there is flow above and below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this one
js/protoblocks.js
Outdated
@@ -1124,6 +1351,10 @@ class ProtoBlock { | |||
} | |||
|
|||
// E.g., count clamp: math block with interior slots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this one
js/protoblocks.js
Outdated
@@ -1162,6 +1398,10 @@ class ProtoBlock { | |||
|
|||
// E.g., action. A "child" flow is docked in an expandable clamp. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this one
js/protoblocks.js
Outdated
@@ -1203,6 +1448,9 @@ class ProtoBlock { | |||
} | |||
|
|||
// E.g., mouse button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one
js/protoblocks.js
Outdated
@@ -1230,6 +1482,9 @@ class ProtoBlock { | |||
} | |||
|
|||
// E.g., named sensor blocks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one...
js/protoblocks.js
Outdated
@@ -1260,6 +1519,9 @@ class ProtoBlock { | |||
} | |||
|
|||
// E.g., not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
js/protoblocks.js
Outdated
@@ -1289,6 +1555,9 @@ class ProtoBlock { | |||
} | |||
|
|||
// E.g., and, or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
js/protoblocks.js
Outdated
@@ -1319,6 +1592,9 @@ class ProtoBlock { | |||
} | |||
|
|||
// E.g., greater, less, equal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
save
js/protoblocks.js
Outdated
@@ -1357,6 +1638,9 @@ class ProtoBlock { | |||
} | |||
|
|||
// E.g., color, shade, pensize, ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so sorry for the inconvenience caused. I'll look into it.
No description provided.