Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation in protoblocks.js #3830

Open
wants to merge 45 commits into
base: master
Choose a base branch
from

Conversation

hackorlyf
Copy link
Contributor

No description provided.

hackorlyf and others added 30 commits February 7, 2024 23:01
@@ -527,6 +632,9 @@ class ProtoBlock {
}
// E.g., distance . Distance block will calculate geometrical distance between two pointa
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this "e.g." belongs in the comment block below (L636)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the rectification walter. I'll correct it and get back to you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had made the necessary changes. Let me know if it's up to Mark or not.

@@ -222,6 +263,10 @@ class ProtoBlock {
}

// E.g., forward, right
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should delete this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walterbender Shifted all the respective comments mentioned by you. Thank you for showing me the ropes.

@@ -252,6 +301,9 @@ class ProtoBlock {
}

// E.g., wait for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line should move into the description below.

@@ -284,6 +340,9 @@ class ProtoBlock {
}

// E.g., setxy. These are expandable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this one.

@@ -325,6 +389,9 @@ class ProtoBlock {
}

// E.g., ??? These are expandable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one can stay.

@@ -409,6 +490,10 @@ class ProtoBlock {
}

// E.g., sqrt, box
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this one...

@@ -442,6 +531,10 @@ class ProtoBlock {
}

// E.g., plus, minus, multiply, divide, power,distance. These are also expandable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this one

@@ -572,6 +686,9 @@ class ProtoBlock {

// E.g., number, string. Value blocks get DOM textareas associated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should move

@@ -633,6 +759,11 @@ class ProtoBlock {

// E.g., start. A "child" flow is docked in an expandable clamp.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should move

@@ -672,6 +808,9 @@ class ProtoBlock {
}

// E.g., emptyclamp. Unlike start, there is a flow above and below.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this one

@@ -711,6 +855,9 @@ class ProtoBlock {
}

// E.g., repeat. Unlike action, there is a flow above and below.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this one...

@@ -753,6 +905,9 @@ class ProtoBlock {

// E.g., tuplet, which takes two args plus an interior flow.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this one

@@ -753,6 +905,9 @@ class ProtoBlock {

// E.g., tuplet, which takes two args plus an interior flow.
// There is a flow above and below.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this one

@@ -835,6 +1003,9 @@ class ProtoBlock {
}

// E.g., do with args: innies instead of interior slots.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this one

@@ -877,6 +1053,9 @@ class ProtoBlock {
}

// E.g., calculate with args: innies instead of interior slots.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one

@@ -919,6 +1103,9 @@ class ProtoBlock {
}

// E.g., named do with args: innies instead of interior slots.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this one

@@ -956,6 +1148,9 @@ class ProtoBlock {
}

// E.g., named calculate with args: innies instead of interior slots.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this one

@@ -995,6 +1195,9 @@ class ProtoBlock {

// E.g., if. A "child" flow is docked in an expandable clamp. The
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this one

@@ -1037,6 +1245,10 @@ class ProtoBlock {
// E.g., if then else. Two "child" flows are docked in expandable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this one

@@ -1086,6 +1304,10 @@ class ProtoBlock {
}

// E.g., forever. Unlike start, there is flow above and below.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this one

@@ -1124,6 +1351,10 @@ class ProtoBlock {
}

// E.g., count clamp: math block with interior slots
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this one

@@ -1162,6 +1398,10 @@ class ProtoBlock {

// E.g., action. A "child" flow is docked in an expandable clamp.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this one

@@ -1203,6 +1448,9 @@ class ProtoBlock {
}

// E.g., mouse button.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one

@@ -1230,6 +1482,9 @@ class ProtoBlock {
}

// E.g., named sensor blocks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one...

@@ -1260,6 +1519,9 @@ class ProtoBlock {
}

// E.g., not
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@@ -1289,6 +1555,9 @@ class ProtoBlock {
}

// E.g., and, or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@@ -1319,6 +1592,9 @@ class ProtoBlock {
}

// E.g., greater, less, equal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

save

@@ -1357,6 +1638,9 @@ class ProtoBlock {
}

// E.g., color, shade, pensize, ...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so sorry for the inconvenience caused. I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants