Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes visibility of clear button #3803

Conversation

Mubashirshariq
Copy link
Contributor

Fixes #3792

This issue was actually occurring because the style top value was being set to original value 76px,whole div was not getting deleted

screen-capture.2.webm

@Mubashirshariq
Copy link
Contributor Author

@walterbender plz review

@walterbender
Copy link
Member

Mosty works. But the buttons end up displaced when you close the aux toolbar.

Screenshot from 2024-03-08 14-49-44

@Mubashirshariq
Copy link
Contributor Author

@walterbender but it works fine for me please see the below video for reference

screen-capture.3.webm

@walterbender
Copy link
Member

On Fedora/Chromium

Maybe you don't need all of these steps, but here is what I did:

  1. clear
  2. open aux toolbar
  3. clear
  4. close aux toolbar
  5. clear
  6. open aux toolbar
  7. close aux toolbar
  8. observe that the buttons are shifted down.

@Mubashirshariq
Copy link
Contributor Author

on ubuntu/chromium
i followed all the above steps as said by you ,but it is working fine.I am sharing the video below for reference

screen-capture.4.webm

Maybe the issue is with you browser

@walterbender
Copy link
Member

Then please test on Chromium. It needs to work there.

@Mubashirshariq
Copy link
Contributor Author

Mubashirshariq commented Mar 9, 2024

@walterbender i tested it on chromium , it is working fine .I don't know why is it not working for you

@pikurasa
Copy link
Collaborator

I don't get the same displacement results as walter.

However, when I resized my browser frame, the confirmation was slightly to the right of where I would expect it.

Screenshot from 2024-03-18 14-13-35
Screenshot from 2024-03-18 14-13-21

Copy link

This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the stale label is removed or commented on.

@github-actions github-actions bot added the Stale label May 17, 2024
Copy link

Closed pull request due to inactivity for more than 63 days.

@github-actions github-actions bot closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirm clear button not visible completely
3 participants