Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #3719 Add Audio File heading and name on svg image in help/guide #3720

Closed
wants to merge 1 commit into from

Conversation

vaishnavi192
Copy link
Contributor

Fix #3719
Added the required headings

@@ -1099,7 +1099,7 @@ function setupToneBlocks(activity) {
*/
constructor() {
// The block name is replaced by a pathname.
super("audiofile", "");
super("audiofile", "AUDIO FILE");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we want the text here; just on the artwork for help.

@pikurasa
Copy link
Collaborator

I noticed that the issue is closed, but this PR is open.

Is there any plan to merge it?

Not sure we want the text here; just on the artwork for help.

Personally, I don't mind having text here. We have text, I think, in all the other SVG help images.

@walterbender
Copy link
Member

If we do want text, it needs to be translated _("AUDIO FILE")

@pikurasa
Copy link
Collaborator

If we do want text, it needs to be translated _("AUDIO FILE")

We already have that text in Music Blocks, so I think we should probably be translating it anyway.

Screenshot from 2024-03-18 14-29-05

FWIW,

音声ファイル | おんせい ファイル

Copy link

This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the stale label is removed or commented on.

@github-actions github-actions bot added the Stale label May 17, 2024
Copy link

Closed pull request due to inactivity for more than 63 days.

@github-actions github-actions bot closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Audio File heading and name on svg image in help/guide
3 participants