[WIP] Changes of sliding plane for turbomachinery #2173

FabianYan2010 · 2023-11-21T11:53:11Z

Adaption of the interpolation method NearestNeighbor to turbomachinery applications when rotating frame is used.

Proposed Changes

If the flow is solved in a rotating frame, the grid is not actutally rotating. But the interpolation for a sliding interface should be done with an actually rotated boundary. The proposed changes add the function of rotating grid points on the boundary of a zone solved in rotating frame before the interpolation is executed. Currently, this is only implemented in CNearestneighbor class, other interpolation method should be changed as well in the near future.

Related Work

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

[ yes ] I am submitting my contribution to the develop branch.
[ yes ] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
[ yes ] My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

…when rotating frame is used.

bigfooted · 2023-11-21T14:39:47Z

Our working branch is 'develop', so you should have started from that and also merge into it. Every 6 months or so we then make the current develop into master. I changed the target branch to develop, and also updated your branch with current develop.
Can you have a look at the failed check for clang-format coding style and format the changed file accordingly?
https://su2code.github.io/docs_v7/Style-Guide/

pcarruscag · 2023-11-21T16:08:57Z

If the mesh is not moving, why are you rotating the search coordinates?

bigfooted · 2024-02-07T15:42:37Z

Should we close this pull request?

…otating frame zone.

…s adopted for unsteady simulation.

…otating frame zone.

…s adopted for unsteady simulation.

FabianYan2010 · 2024-02-19T08:25:55Z

If the mesh is not moving, why are you rotating the search coordinates?

I'm so sorry for the belated response! I was trying to debug and test the new feature and to give a proper pull-request.
As for the question:
Because we are using rotating frame for rotor. In rotating frame we consider the rotating effect by adding source terms in governing equations so that the mesh movement is spared. But when we transfer data between rotor and stator for unsteady simulation, the rotor side has to be rotated to match the reality. The rotor is actually rotating, so as the flow phenomena, like rotor wakes passing through the interface. Otherwise, we will see non-rotating wakes in the stator frame of reference. Every time step, the matching grid points between two sides need to be updated as well.

FabianYan2010 · 2024-02-19T08:33:16Z

Our working branch is 'develop', so you should have started from that and also merge into it. Every 6 months or so we then make the current develop into master. I changed the target branch to develop, and also updated your branch with current develop. Can you have a look at the failed check for clang-format coding style and format the changed file accordingly? https://su2code.github.io/docs_v7/Style-Guide/

Thanks a lot! It's very much appreciated. I have implemented the clang-format according to the guide and force formatting all files by using 'pre-commit run -a'. I think the new commits should be conformed to the coding style but not sure if the previous commit is also changed.

pcarruscag · 2024-02-19T16:11:22Z

That's not consistent with any code I know, when using the MRF approach you either get frozen rotor or mixing plane interfaces. If you want a more accurate simulation you move the mesh and update the interfaces, there are several advantages to not dealing with the MRF source terms. There are also practical aspects of not updating the interface when doing transient MRF, for example it lets you handle interfaces that are not cylindrical, people use this to model car wheels.
MRF is also less restrictive for time step size than moving mesh, but if you move the interface you bring some of the moving mesh restrictions to MRF. So my impression is that this strategy combines some of the downsides of both approaches...

FabianYan2010 · 2024-02-20T09:17:15Z

Thanks for your comments! Except for mixing plane and frozen rotor, sliding plane is also pretty common in turbomachinery simulation, it is indeed implemented in some, if not all, in-house codes.
MRF is quite useful in turbomachinery simulation, expecially when we deal with transient simulation. Actually it is really rare to move the rotor mesh like in reality. One reason is that MRF is more efficient and accurate. Otherwise, you introduce new disturbance into the transient flow field every physical time step, which is not good. Because when you rotate the mesh, the velocity direction of each grid point inherited from last time step is not rotated. To make it more clear, you will have a flow going towards casing instead of parallel to, at the start of next physical time step. So you need more pseudo time steps to get a proper velocity variable. As a result, you get a zig-zag shape in the residual history.
I'm not actually moving the interface. The rotor mesh is not rotated, so as the interface at rotor zone. I'm just virtually rotating the rotor interface to find the new matching points between rotor and stator for each physical time step, so that the variable could be passed across the interface. In other words, only the passing variables are actually rotated. If I understand it correctly, there is no additional moving mesh restriction introduced here.

pcarruscag · 2024-02-25T17:01:47Z

Updating the interface creates relative motion and thus you have blade-passing frequencies to resolve, which require more detail to resolve than just rotation.
If you want this as a different option that's fine, but it's not going to be the default.

So we merge the mods on it to its real destination. Merge branch 'master' into turbo_features_fabian

…ull-annulus) computation restarted from a single-passage solution

…e(e.g. full-annulus simulation)

SU2_CFD/src/solvers/CSolver.cpp

+
+			if (iPoint_Local > -1) {
+
+				for (iVar = 0; iVar < Restart_Vars[1]; iVar++)


SU2_CFD/src/solvers/CSolver.cpp


-      for (iVar = 0; iVar < Restart_Vars[1]; iVar++)
-        Restart_Data[counter*Restart_Vars[1] + iVar] = SU2_TYPE::GetValue(PrintingToolbox::stod(point_line[iVar+1]));
+        for (iVar = 0; iVar < Restart_Vars[1]; iVar++)


SU2_CFD/src/interfaces/cfd/CSlidingInterface.cpp

+
+		unsigned short nDim = target_geometry->GetnDim();
+
+		su2double Theta, Phi, Psi, cosTheta, sinTheta, cosPhi, sinPhi, cosPsi, sinPsi;


SU2_CFD/src/interfaces/cfd/CSlidingInterface.cpp

+
+		unsigned short nDim = target_geometry->GetnDim();
+
+		su2double Theta, Phi, Psi, cosTheta, sinTheta, cosPhi, sinPhi, cosPsi, sinPsi;


SU2_CFD/src/interfaces/cfd/CSlidingInterface.cpp

+
+		unsigned short nDim = target_geometry->GetnDim();
+
+		su2double Theta, Phi, Psi, cosTheta, sinTheta, cosPhi, sinPhi, cosPsi, sinPsi;


SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

+    //bool Fullannulus = false;
+    //if (geometry[MESH_0]->GetnPassages() == geometry[MESH_0]->GetnPassages_FullAnnu())
+    //	Fullannulus = true;


SU2_CFD/src/solvers/CSolver.cpp

+  long PsgIndx_RemPer;
+  unsigned long GlobalIndx_FullAnnu;
+  unsigned long nPsgPoint_RemPer = geometry->GetGlobal_nPsgPoint_RemPer();
+  //bool Fullannulus = false;


SU2_CFD/src/solvers/CSolver.cpp

@@ -2858,37 +2858,92 @@

  Restart_Data.resize(Restart_Vars[1]*geometry->GetnPointDomain());

-  /*--- Read all lines in the restart file and extract data. ---*/
+  //bool FullAnnu_Transform = 1; 


SU2_CFD/src/solvers/CTurbSolver.cpp

+          counter++;
+        }
+
+        //cout<<"iPoint_Local "<<iPoint_Local<<", GlobalIndx_FullAnnu "<<GlobalIndx_FullAnnu<<endl;


SU2_CFD/src/solvers/CTurbSolver.cpp

+      //bool Fullannulus = false;
+    //if (geometry[MESH_0]->GetnPassages() == geometry[MESH_0]->GetnPassages_FullAnnu())
+    //	Fullannulus = true;


…teral element on sliding interfaces ( previously, it works only for triangles), which is very common in turbomachinery applications.

…010/SU2 into turbo_features_fabian

pcarruscag

@FabianYan2010 can you separate the different features you are working on into different PRs please? I think I count 4 quite large ones already.

adapt the interpolation method NearestNeighbor to turbo applications …

d9b04db

…when rotating frame is used.

bigfooted changed the base branch from master to develop November 21, 2023 14:32

Merge branch 'develop' into turbo_features_fabian

4461aa4

chuanxiang yan added 7 commits February 18, 2024 14:50

For interface data broadcasting, we rotate the velocity vector from r…

76510d8

…otating frame zone.

Update transfer coefficient every time step for when rotating frame i…

4477eff

…s adopted for unsteady simulation.

For interface data broadcasting, we rotate the velocity vector from r…

5727ae6

…otating frame zone.

For interface data broadcasting, we rotate the velocity vector from r…

f798a6b

…otating frame zone.

For interface data broadcasting, we rotate the velocity vector from r…

d040cc4

…otating frame zone.

Update transfer coefficient every time step for when rotating frame i…

c3fe7d2

…s adopted for unsteady simulation.

New testcase proposed for this feature.

81ed71e

FabianYan2010 and others added 5 commits May 13, 2024 15:44

Merge branch 'su2code:master' into turbo_features_fabian

4d32555

update Merge branch 'master' of https://github.com/FabianYan2010/SU2

5f2f6ef

Master branch was accidentally changed.

1fbc798

So we merge the mods on it to its real destination. Merge branch 'master' into turbo_features_fabian

A new turbomachinery feature of enabling a multi-passage (including f…

6ac8c4a

…ull-annulus) computation restarted from a single-passage solution

Compute NSpan for turbomachinery when no periodic boundry is availabl…

c476871

…e(e.g. full-annulus simulation)

bigfooted changed the title ~~Changes of sliding plane for turbomachinery~~ [WIP] Changes of sliding plane for turbomachinery May 31, 2024

bigfooted added the PR: draft label May 31, 2024

Merge branch 'develop' into turbo_features_fabian

50b075c

github-advanced-security bot found potential problems May 31, 2024

View reviewed changes

chuanxiang yan added 2 commits June 3, 2024 12:34

Adapt the SlidingMesh interpolation method to accomodate the quadrila…

68406b5

…teral element on sliding interfaces ( previously, it works only for triangles), which is very common in turbomachinery applications.

Merge branch 'turbo_features_fabian' of https://github.com/FabianYan2…

c748e06

…010/SU2 into turbo_features_fabian

pcarruscag reviewed Jun 3, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Changes of sliding plane for turbomachinery #2173

[WIP] Changes of sliding plane for turbomachinery #2173

FabianYan2010 commented Nov 21, 2023

bigfooted commented Nov 21, 2023

pcarruscag commented Nov 21, 2023

bigfooted commented Feb 7, 2024

FabianYan2010 commented Feb 19, 2024

FabianYan2010 commented Feb 19, 2024

pcarruscag commented Feb 19, 2024

FabianYan2010 commented Feb 20, 2024

pcarruscag commented Feb 25, 2024

pcarruscag left a comment


		if (iPoint_Local > -1) {

		for (iVar = 0; iVar < Restart_Vars[1]; iVar++)


		unsigned short nDim = target_geometry->GetnDim();

		su2double Theta, Phi, Psi, cosTheta, sinTheta, cosPhi, sinPhi, cosPsi, sinPsi;

[WIP] Changes of sliding plane for turbomachinery #2173

Are you sure you want to change the base?

[WIP] Changes of sliding plane for turbomachinery #2173

Conversation

FabianYan2010 commented Nov 21, 2023

Proposed Changes

Related Work

PR Checklist

bigfooted commented Nov 21, 2023

pcarruscag commented Nov 21, 2023

bigfooted commented Feb 7, 2024

FabianYan2010 commented Feb 19, 2024

FabianYan2010 commented Feb 19, 2024

pcarruscag commented Feb 19, 2024

FabianYan2010 commented Feb 20, 2024

pcarruscag commented Feb 25, 2024

pcarruscag left a comment

Choose a reason for hiding this comment