Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix volume names #2079

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from
Open

[WIP] fix volume names #2079

wants to merge 22 commits into from

Conversation

bigfooted
Copy link
Contributor

Proposed Changes

For volume names, we assume that the filename is filename.ext and we strip the extension using find_last_of('.')
But:

  1. This can lead to unwanted file stripping when you want the filename or folder to be volume.a
  2. We already mention in the documentation that the volume filename should be given without an extension

I think we should simply remove the find_last_of lines. There are more of those, for now I have simply removed the one connected to #2074

Related Work

Issue: #2074

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@bigfooted
Copy link
Contributor Author

There are some other find_last_of lines as well, if all filenames are supposed to be given without any file extension, then these should all be removed.

@pcarruscag
Copy link
Member

In principle sounds good, it will probably break lots of cases, optimization scripts and what not. We'll see, we are not leaving this inconsistent though, all or nothing.

@bigfooted
Copy link
Contributor Author

In principle sounds good, it will probably break lots of cases, optimization scripts and what not. We'll see, we are not leaving this inconsistent though, all or nothing.

I agree.

@pcarruscag pcarruscag changed the title fix volume names [WIP] fix volume names Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants