[WIP] Isothermal streamwise periodicity #1799

NAnand-TUD · 2022-10-27T06:32:23Z

Proposed Changes

Implementation of Streamwise periodic Iso-thermal BCs

Related Work

This is an add-on to the already existing Streamwise periodic flow solver. As a result, there are new source terms which are accounted for in the solution.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

[X ] I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

…h BCs are working, verification study to follow

…dient validation pending

… flow cases

bigfooted · 2022-10-27T12:00:16Z

Hi Nitish, can you remove the codi and opdi changes from the PR? This happens when your local codi/opdi is not up to date, so you should update these submodules.

Common/include/option_structure.hpp

NAnand-TUD · 2022-10-27T14:32:25Z

@bigfooted, Thanks for your comment. I tried but it was not reflected. I see that during the merge with develop the submodule commit keys got updated. Any clues how I can do this ?

…was failing, this should fix it.

…into feature_isothermalSWP

NAnand-TUD · 2022-10-28T19:37:20Z

All tests are now passing, except CodeFactor. But I guess that was there even before I implemented anything. @bigfooted : Thanks for your commit.

Common/include/CConfig.hpp

SU2_CFD/src/numerics/flow/flow_sources.cpp

SU2_CFD/src/output/CFlowIncOutput.cpp

SU2_CFD/src/solvers/CIncNSSolver.cpp

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

…into feature_isothermalSWP

NAnand-TUD · 2022-11-10T22:46:05Z

SU2_CFD/src/solvers/CIncNSSolver.cpp

+          const auto AreaNormal = geometry->vertex[iMarker][iVertex]->GetNormal();
+
+          su2double GradT[MAXNDIM] = {0.0,0.0,0.0};
+          for (auto iDim = 0u; iDim < nDim; iDim++)


So I have to revert this as GetGradient_Primitive gives a Matrix su2double which does not comply with DotProduct. I saw at other parts of the code for loop being used to construct a variable and then do DotProduct.

Do you know a better way to handle this?

Sorry, slightly wrong suggestion, do this instead please:

const auto GradT = nodes->GetGradient_Primitive(iPoint)[prim_idx.Temperature()];

NAnand-TUD · 2022-11-10T22:46:45Z

Common/src/CConfig.cpp

-    if (Energy_Equation && Streamwise_Periodic_Temperature && nMarker_Isothermal != 0)
-      SU2_MPI::Error("No MARKER_ISOTHERMAL marker allowed with STREAMWISE_PERIODIC_TEMPERATURE= YES, only MARKER_HEATFLUX & MARKER_SYM.", CURRENT_FUNCTION);
+    if (Energy_Equation && Streamwise_Periodic_Temperature && nMarker_Isothermal > 0 && nMarker_HeatFlux > 0)
+      SU2_MPI::Error("MARKER_ISOTHERMAL and MARKER_HEATFLUX are not allowed simultaneously with STREAMWISE_PERIODIC_TEMPERATURE= YES, only one of these is allowed MARKER_ISOTHERMAL, MARKER_HEATFLUX in a fluid zone.", CURRENT_FUNCTION);


Do you see any edge case that might pass this?

Looks ok but @TobiKattmann should know better

stale · 2023-05-21T21:02:44Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions.

…into feature_isothermalSWP

…dic direction z

github-advanced-security

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

SU2_CFD/src/solvers/CHeatSolver.cpp

+
+//     } // points
+
+// }


SU2_CFD/src/solvers/CHeatSolver.cpp

+//       if (turbulent && (config->GetnMarker_Isothermal() != 0))
+//         turb_b1_coeff_Local += Temp * nodes->GetAuxVarGradient(iPoint, 0, 0) * config->GetSpecific_Heat_Cp() * volume  / config->GetPrandtl_Turb();
+
+//       Volume_VTemp_Local += volume * Temp * nodes->GetVelocity(iPoint, 2) * nodes->GetDensity(iPoint);


SU2_CFD/src/solvers/CHeatSolver.cpp

+
+//       Volume_TempS_Local += volume * Temp;
+
+//       Volume_Temp_Local += volume * Temp * nodes->GetThermalConductivity(iPoint);


SU2_CFD/src/solvers/CHeatSolver.cpp

+
+//       Volume_Local += volume;
+
+//       Volume_TempS_Local += volume * Temp;


SU2_CFD/src/solvers/CHeatSolver.cpp

+
+//       const su2double Temp = nodes->GetTemperature(iPoint);
+
+//       Volume_Local += volume;


SU2_CFD/src/numerics/flow/flow_sources.cpp

+  if (implicit) {
+
+    // /*--- Jacobian is set to zero on initialization. ---*/

-      /*--- Compute a scalar factor ---*/
-      scalar_factor = SPvals.Streamwise_Periodic_IntegratedHeatFlow / (SPvals.Streamwise_Periodic_MassFlow * sqrt(norm2_translation) * Prandtl_Turb);
+    // jacobian[nDim+1][nDim+1] = Volume * scalar_factor * dot_product;
+
+  }


SU2_CFD/src/numerics/flow/flow_sources.cpp

+        if (implicit) {
+
+        // /*--- Jacobian is set to zero on initialization. ---*/
+
+        // jacobian[nDim+1][nDim+1] -= Volume * scalar_factor * dot_product;
+
+        }


SU2_CFD/src/numerics/flow/flow_sources.cpp

+
+        // /*--- Jacobian is set to zero on initialization. ---*/
+
+        // jacobian[nDim+1][nDim+1] -= Volume * scalar_factor * dot_product;


SU2_CFD/src/numerics/flow/flow_sources.cpp


-      /*--- Compute a scalar factor ---*/
-      scalar_factor = SPvals.Streamwise_Periodic_IntegratedHeatFlow / (SPvals.Streamwise_Periodic_MassFlow * sqrt(norm2_translation) * Prandtl_Turb);
+    // jacobian[nDim+1][nDim+1] = Volume * scalar_factor * dot_product;


SU2_CFD/src/solvers/CIncNSSolver.cpp

+        for (unsigned short iDim = 0; iDim < nDim; iDim++) {
+          dot_product += config->GetPeriodic_Translation(0)[iDim]* nodes->GetAuxVarGradient(iPoint, 0, iDim);
+        }
+        // su2double dot_product = GeometryToolbox::DotProduct(nDim, config->GetPeriodic_Translation(0), nodes->GetAuxVarGradient(iPoint, 0));


NAnand-TUD and others added 13 commits July 6, 2022 17:38

NS iso thermal implementation working

514fd95

Merge branch 'develop' into feature_isothermalSWP

449c16a

Volume averaged temperature computation shifted

97820a2

clean-up and seperation of iso-thermal and heat flux SWP sources, bot…

fa1f38a

…h BCs are working, verification study to follow

iso-thermal objectives still not getting validated

15a5eb2

Turbulent isothermal source terms added, validation pending

fd9afe2

Quadratic term for turbulent equations, solution verification and gra…

988b5a9

…dient validation pending

Gradient Validation for Lambda L is working for Laminar and Turbulent…

978a87f

… flow cases

cleaning and comments

26f3339

Small correction to the source terms

9799d82

Correction to the SourceTerms to compute turbulent Lambda

c6e1277

Merge remote-tracking branch 'origin/develop' into feature_isothermalSWP

0425778

Merged with develop, minor verification in process

3eaa05e

NAnand-TUD requested review from TobiKattmann and pcarruscag October 27, 2022 06:32

pr-triage bot added the PR: draft label Oct 27, 2022

WallyMaier reviewed Oct 27, 2022

View reviewed changes

Common/include/option_structure.hpp Outdated Show resolved Hide resolved

complying with the PR suggestions

e383836

NAnand-TUD and others added 5 commits October 27, 2022 18:35

Build failing due to errors. This should pass hopefully 1

5651b3d

Build failing due to errors. This should pass hopefully 2

f0a817c

Merge branch 'develop' into feature_isothermalSWP

71c3d95

Build failing due to errors. This should pass hopefully 3, unit test …

2f4888f

…was failing, this should fix it.

Merge branch 'feature_isothermalSWP' of https://github.com/su2code/SU2 …

a777bd6

…into feature_isothermalSWP

pcarruscag reviewed Oct 28, 2022

View reviewed changes

pcarruscag changed the title ~~Feature isothermal swp~~ [WIP] Isothermal streamwise periodicity Oct 28, 2022

pcarruscag added the changelog:feature label Oct 28, 2022

complying with the PR suggestions, Pedro comments.

19e3f41

NAnand-TUD and others added 6 commits November 10, 2022 19:23

Update SU2_CFD/src/output/CFlowIncOutput.cpp

c931b98

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/src/output/CFlowIncOutput.cpp

03fe2ad

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

V_i suggestion and CConfig fixed

78b0ab0

Merge branch 'feature_isothermalSWP' of https://github.com/su2code/SU2 …

0f4bb42

…into feature_isothermalSWP

fixed error with DotProduct

50360de

Submodule commits updated

d67666b

NAnand-TUD commented Nov 10, 2022

View reviewed changes

Nitish Annad added 2 commits November 11, 2022 11:04

CConfig error tested and CIncNSSolver implemented

99e39e8

Merged with develop

bec2016

stale bot added the stale label May 21, 2023

NAnand-TUD added 3 commits July 11, 2023 12:07

Merge branch 'develop' into feature_isothermalSWP

5e4b0a8

Merge branch 'feature_isothermalSWP' of https://github.com/su2code/SU2 …

c0ae9fd

…into feature_isothermalSWP

Merged with develop, submodules updated

8c5f3f4

stale bot removed the stale label Jul 11, 2023

NAnand-TUD added 8 commits August 9, 2023 21:51

Changes to make z direction flow work

b1f7acb

sdsd

2f95ece

Merge branch 'feature_isothermalSWP' of https://github.com/su2code/SU2 …

fc0caaf

…into feature_isothermalSWP

2D/3D SWP-isothermal generalized, 2D- periodic direction y, 3D- perio…

5ef89a5

…dic direction z

Merge branch 'develop' into feature_isothermalSWP

abfa537

Bug fix

688d8ea

merged with develop

6f80a62

submodules updated

0f2e642

github-advanced-security bot found potential problems Oct 30, 2023

View reviewed changes

NAnand-TUD added 2 commits October 31, 2023 09:48

addressing warnings

93532b2

3D Generalization - testing

52fc485

github-advanced-security bot found potential problems Jan 30, 2024

View reviewed changes

NAnand-TUD added 2 commits April 11, 2024 16:19

writing and raeding LAMBDAL into the flow.meta file

804d89d

Fix: Gradient Validation for Massflow based SWP Solver

ce08528

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Isothermal streamwise periodicity #1799

[WIP] Isothermal streamwise periodicity #1799

NAnand-TUD commented Oct 27, 2022

bigfooted commented Oct 27, 2022

NAnand-TUD commented Oct 27, 2022

NAnand-TUD commented Oct 28, 2022

NAnand-TUD Nov 10, 2022

pcarruscag Nov 11, 2022

NAnand-TUD Nov 10, 2022

pcarruscag Nov 11, 2022

stale bot commented May 21, 2023

github-advanced-security bot left a comment


		// Volume_TempS_Local += volume * Temp;

		// Volume_Temp_Local += volume * Temp * nodes->GetThermalConductivity(iPoint);


		// Volume_Local += volume;

		// Volume_TempS_Local += volume * Temp;


		// const su2double Temp = nodes->GetTemperature(iPoint);

		// Volume_Local += volume;


		// /--- Jacobian is set to zero on initialization. ---/

		// jacobian[nDim+1][nDim+1] -= Volume * scalar_factor * dot_product;

[WIP] Isothermal streamwise periodicity #1799

Are you sure you want to change the base?

[WIP] Isothermal streamwise periodicity #1799

Conversation

NAnand-TUD commented Oct 27, 2022

Proposed Changes

Related Work

PR Checklist

bigfooted commented Oct 27, 2022

NAnand-TUD commented Oct 27, 2022

NAnand-TUD commented Oct 28, 2022

NAnand-TUD Nov 10, 2022

Choose a reason for hiding this comment

pcarruscag Nov 11, 2022

Choose a reason for hiding this comment

NAnand-TUD Nov 10, 2022

Choose a reason for hiding this comment

pcarruscag Nov 11, 2022

Choose a reason for hiding this comment

stale bot commented May 21, 2023

github-advanced-security bot left a comment

Choose a reason for hiding this comment