Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"PARAVIEW_MULTIBLOCK" issue with path that contains period #2074

Open
idocruhman opened this issue Jul 9, 2023 · 4 comments
Open

"PARAVIEW_MULTIBLOCK" issue with path that contains period #2074

idocruhman opened this issue Jul 9, 2023 · 4 comments
Assignees
Labels

Comments

@idocruhman
Copy link

I have enabled the writing of the individual surfaces using the "PARAVIEW_MULTIBLOCK" directive.
The folder was created on the wrong place because the path contained periods.
for a simulation run in /foo/bar/polar_M0.6/aoa0/config.cfg
the folder was created in /foo/bar/polar_M0/zone_0
I assume this is due to the foder name being generated by cutting the path at the first period to remove the .cfg from the name.
While I understand that chaging the name will fix the issue, a period is a legal character for a folder name.

  • OS: Centos 7.5
  • C++ compiler and version: not sure
  • MPI implementation and version: not sure
  • SU2 Version: 7.5.0
@idocruhman idocruhman added the bug label Jul 9, 2023
@bigfooted
Copy link
Contributor

We actually do a find_last_of('.'), which strips the filename extension, if it exists. But it leads to the problem that you describe if the filename does not have an extension but the folder name does.
The documentation says that VOLUME_FILENAME should be provided without the extension/suffix, so we could also remove the find_last_of('.') to prevent unwanted chopping of the folders and filenames.

@pcarruscag
Copy link
Member

We can check for the last "." that is after the last / (if one exists).

@bigfooted
Copy link
Contributor

Maybe a user wants filenames like flow.a, flow.b, and I think we should allow this.
I think we should not be too smart about it and not strip anything. Then the code does what the documentation says it does.

@pcarruscag
Copy link
Member

Ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants