Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: opentk link #2248

Merged
merged 2 commits into from
May 18, 2024
Merged

fix: opentk link #2248

merged 2 commits into from
May 18, 2024

Conversation

Doprez
Copy link
Contributor

@Doprez Doprez commented May 14, 2024

PR Details

Fixes the URL of one of the third party links.

Related Issue

#2229

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Doprez Doprez marked this pull request as ready for review May 14, 2024 23:56
Jklawreszuk
Jklawreszuk reviewed May 15, 2024
View reviewed changes
Copy link
Collaborator

@Jklawreszuk Jklawreszuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on a second, Didn't we switched to Silk.NET.OpenGL? 👀

@Doprez
Copy link
Contributor Author

Doprez commented May 16, 2024

I think you are correct, I wasnt sure if I should just remove it or keep it for historical reasons.

@Jklawreszuk
Copy link
Collaborator

I would suggest deleting this line, because information about OpenTK usage will be still available via previous master branch versions like master-4.1, master-4.0 etc, so It is only confusing

@Doprez
Copy link
Contributor Author

Doprez commented May 16, 2024

Definitely makes more sense. It has now been removed.

@Eideren Eideren added the area-Doc Issues related to documentation label May 18, 2024
@Eideren Eideren merged commit c4336f2 into stride3d:master May 18, 2024
2 checks passed
@Eideren
Copy link
Collaborator

Eideren commented May 18, 2024

Thanks !

@Eideren Eideren changed the title fix opentk link fix: opentk link May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jklawreszuk Jklawreszuk Jklawreszuk approved these changes

Assignees
No one assigned
Labels
area-Doc Issues related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Doprez @Jklawreszuk @Eideren