Fix is_fragment_run page profile field #8670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to temporarily set the |
kajarenc
approved these changes
May 15, 2024
|
LGTM to merge after @ sfc-gh-amiribel checks! |
raethlein
approved these changes
May 15, 2024
vdonato
force-pushed
the
vdonato/fix/is_fragment_run
branch
from
784235c
to
86107a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out setting the
is_fragment_runfield using whetherctx.current_fragment_idis set doesn'twork correctly since page profile messages are created after
ctx.current_fragment_idhas alreadybeen reset. This PR fixes the field by instead setting it to true if the
ctx.fragment_ids_this_runset istruthy.