Rework create-strapi-xxx #20268
Open
Rework create-strapi-xxx #20268
+663
−1,620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrebodin
added
source: cli
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Marc-Roig
reviewed
May 7, 2024
Marc-Roig
reviewed
May 7, 2024
|
rework looks good to me! let me know when this is ready to be reviewed and I can QA :) Also, does it make sense to do some tests on different options to validate it works as intended? |
alexandrebodin
force-pushed
the
enh/cli
branch
2 times, most recently
from
08f2ec0
to
80361bb
Compare
|
Size Change: -144 B (-0.01%) Total Size: 2.53 MB
ℹ️ View Unchanged
|
Marc-Roig
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Did QA with yarn and pnpm, nice ✨
- Could you document in the generators README this can be tested by using
./node_modules/.bin/create-strapi-app?
Also, I am going to create a ticket, once creating a new strapi app, I can only see these pages:
I need to reload the server to see the rest of pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Why is it needed?
How to test it?
./node_modules/.bin/create-strapi-app