Allow user to manually input password when bio-metric fails #19989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parveshdhull
commented
May 12, 2024
| @@ -33,6 +33,8 @@ | |||
| args-with-biometric-btn]) | |||
| :on-success #(rf/dispatch [:standard-auth/on-biometric-success on-auth-success]) | |||
| :on-fail (fn [err] | |||
| (rf/dispatch [:standard-auth/authorize-with-password | |||
There was a problem hiding this comment.
(when (and err
(string/includes?
(string/lower-case
(:orig-error-message (.-data err)))
"too many attempts"))
I initially added a condition here to only show password input when too many attempt. But I think user should be able to manually input password when bio-metric fails, even if due to some other reason.
Jenkins BuildsClick to see older builds (8)
|
|
@clauxx is this leftover, or by choice
I mean, we have access to original error "Too many failed attempts", So I think we should show that to user instead of unknown error. wdyt? |
|
@Parveshdhull - would be nice to include a video/ images if this affects the UI in any way ? 🤔 |
|
Thank you @J-Son89, updated the description with the video. btw, video shows unknown error, but as I mentioned in #19989 (comment), we have access to actual error. So maybe can show "Too many attempts" instead of unknown error. We can address that later. |
|
thanks @Parveshdhull - yep it would be great to have the proper error as unknown just looks like something went wrong but not necessarily the users fault. Fine to do in a follow up 👍 |
J-Son89
approved these changes
May 13, 2024
Parveshdhull
force-pushed
the
fix/biometric-auth
branch
from
c3ce4ea
to
2ca121b
Compare
52% of end-end tests have passedFailed tests (23)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (27)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
|
Sorry for the late reply. No it wasn't intended, this solution makes sense, thanks 👍 |
clauxx
approved these changes
May 14, 2024
qoqobolo
force-pushed
the
fix/biometric-auth
branch
from
2ca121b
to
678b8cc
Compare
67% of end-end tests have passedFailed tests (15)Click to expandClass TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (35)Click to expandClass TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
80% of end-end tests have passedFailed tests (3)Click to expandClass TestWalletMultipleDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (12)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
|
Hey @Parveshdhull, thanks for the fix! If a user fails all biometric attempts and then enters a password manually, e.g. when creating a wallet account, then the next time they need to use biometrics again (e.g. for creating another wallet account or even relogin), they won't be able to use it and will immediately get this error again. So two questions:
Note: on iOS I can use biometrics again after getting the error and entering my password manually Steps to reproduce to make it more clear:
video_2024-05-17_15-00-39.mp4
|
|
hi @qoqobolo, thank you very much for testing the PR.
I think it also gets fixed by itself after some time 🤔
No, we will only show error (too many attempts), or probably probably better if we could show "Too many attempts, try after some time or enter password manually". wdyt? Also about informing user process making it work by entering device password etc.. I think we probably should not give this information to user, because biometric is os/device specific. We can't be sure, what will work on which device. |
This sounds good to me 👍 Thanks for the clarification and for updating the issue! |
Parveshdhull
force-pushed
the
fix/biometric-auth
branch
from
678b8cc
to
f5e3d2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19488
Video
cut.mp4
status: ready