(TEST) Change to run Coordinator tests on JDK 20 #2783
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coordinator/persistence-api/src/test/java/io/stargate/db/query/builder/BuiltSelectTest.java
Outdated
Show resolved
Hide resolved
...nce-common/src/main/java/io/stargate/db/datastore/common/util/UserDefinedFunctionHelper.java
Show resolved
Hide resolved
coordinator/pom.xml
Outdated
| <!-- JDK 11 settings --> | ||
| <jdk11.module-exports>--add-exports java.base/jdk.internal.ref=ALL-UNNAMED --add-exports java.base/jdk.internal.misc=ALL-UNNAMED</jdk11.module-exports> | ||
| <!-- JDK 9+ JPMS settings --> | ||
| <jdk11.module-exports>--add-opens java.base/java.io=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.nio=ALL-UNNAMED --add-opens java.base/java.nio.file.spi=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.util.concurrent=ALL-UNNAMED --add-opens java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens java.base/jdk.internal.ref=ALL-UNNAMED --add-opens java.base/jdk.internal.misc=ALL-UNNAMED --add-opens java.base/sun.nio.ch=ALL-UNNAMED</jdk11.module-exports> |
There was a problem hiding this comment.
This is quite close to set of exports added in CNDB/vsearch. Using --add-opens since some reflection usage needs that (which gives more access than --add-exports). Probably not all entries strictly needed but were at some point in time and lots of work to run through the whole test suite to weed out ones not actually needed.
… failure of backends
tatu-at-datastax
changed the title
QueryBuilder generation with direct use of QueryBuilderImpl
tatu-at-datastax
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Changes
QueryBuilderImpl,SchemaBuilderImplto be usable without Duzzt-based code generation.Which issue(s) this PR fixes:
Fixes #2781
Checklist