PR: Group everything the Layout plugin does before the main window is visible on it #19509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
changed the title
dalthviz
reviewed
Sep 20, 2022
There was a problem hiding this comment.
Thanks @ccordoba12 ! I checked locally and seems that things are working except for the first time I opened Spyder with this changes. When I did that I got this initial layout:
Not totally sure why but, after rearranging the layout, subsequent launches preserved correctly the layout.
Other than that this LGTM 👍
|
Maybe the issue I got before is related with #19084 ? |
You opened it with clean settings or with your previous ones? |
|
I runned with the previous ones |
|
I can't reproduce this on Linux, but leaving for 5.4.1 because it's not critical. |
harshsingh32
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This is a small refactoring that continues the trend of consolidating everything related to adjusting the main window layout in the Layout plugin and not on
MainWindow.Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12