Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #1495 and #1387 AnsiConsole.Write(string value) uses format string #1516

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BlazeFace
Copy link
Contributor

@BlazeFace BlazeFace commented Apr 14, 2024

Restore parity between write and write line

fixes #1495 #1387

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

Updating Write to be inline with the functionality of WriteLine where string format is only used when an args object array is included in the method call.


Please upvote 👍 this pull request if you are interested in it.

…tring to restore parity between write and write line
@BlazeFace BlazeFace changed the title Fixing #1495 AnsiConsole.Write(string value) uses format string Fixing #1495 and #1387 AnsiConsole.Write(string value) uses format string Apr 14, 2024
@github-actions github-actions bot added the ⭐ top pull request Top pull request. label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ top pull request Top pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Input string was not in a correct format" error with AnsiConsole.Write()
1 participant