Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perl-xml-libxml: add v2.0210, v2.0209 #44254

Merged

Conversation

teaguesterling
Copy link
Contributor

Addresses perl-xml-libxml issue with gcc@14. (#44253)

Copy link

spackbot-app bot commented May 18, 2024

Hi @teaguesterling! I noticed that the following package(s) don't yet have maintainers:

  • perl-xml-libxml

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("teaguesterling")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame perl-xml-libxml

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@teaguesterling
Copy link
Contributor Author

@spackbot fix style

Copy link

spackbot-app bot commented May 18, 2024

Let me see if I can fix that for you!

Copy link

spackbot-app bot commented May 18, 2024

I was able to run spack style --fix for you!

spack style --fix
==> Running style checks on spack
  selected: isort, black, flake8, mypy
==> Modified files
  var/spack/repos/builtin/packages/perl-xml-libxml/package.py
==> Running isort checks
  isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/perl-xml-libxml/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> Running mypy checks
lib/spack/spack/version/version_types.py:145: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/version/version_types.py:452: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/version/version_types.py:481: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
Found 3 errors in 1 file (checked 625 source files)
  mypy found errors
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

@teaguesterling teaguesterling marked this pull request as ready for review May 18, 2024 14:17
Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>
@wdconinc wdconinc changed the title Address #44253 by adding new versions and declaring conflicts for per… perl-xml-libxml: add new versions and conflicts (fixes #44253) May 18, 2024
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified checksums. Thanks!

@wdconinc wdconinc self-assigned this May 18, 2024
@wdconinc wdconinc enabled auto-merge (squash) May 18, 2024 14:53
@wdconinc wdconinc merged commit 36af1c1 into spack:develop May 18, 2024
14 checks passed
@alecbcs alecbcs changed the title perl-xml-libxml: add new versions and conflicts (fixes #44253) perl-xml-libxml: add v2.0210, v2.0209 May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants