Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mvapich support for intel scalapack_libs #44246

Merged
merged 3 commits into from
May 24, 2024

Conversation

khsa1
Copy link
Contributor

@khsa1 khsa1 commented May 17, 2024

The correct scalapack libs are set for mvapich2 with Intel but mvapich@3.0 uses mvapich, not mvapich2.

@spackbot-app spackbot-app bot added build-systems core PR affects Spack core functionality labels May 17, 2024
alalazo
alalazo previously approved these changes May 17, 2024
Copy link
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for @rscohn2 to comment. Do we need to change anything in OneAPI packages, along the same lines?

@alalazo alalazo self-assigned this May 17, 2024
@alalazo alalazo requested a review from rscohn2 May 17, 2024 16:11
@khsa1
Copy link
Contributor Author

khsa1 commented May 17, 2024

I ran into this issue while building cp2k with oneapi. I'm not sure what the interaction is between the intel and oneapi build systems. Maybe someone on the spack team can provide more insight?

@rscohn2
Copy link
Member

rscohn2 commented May 18, 2024

I ran into this issue while building cp2k with oneapi. I'm not sure what the interaction is between the intel and oneapi build systems. Maybe someone on the spack team can provide more insight?

oneapi has a separate build system and the equivalent logic is in the intel-oneapi-mkl package:

It tries to guess based on package name, and also has mpi_family variant for explicit control if the package is not recognized. We are missing mvapich and mvapich2. Could you add them?

@khsa1
Copy link
Contributor Author

khsa1 commented May 23, 2024

Sure, just pushed that

Copy link
Member

@rscohn2 rscohn2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rscohn2 rscohn2 enabled auto-merge (squash) May 23, 2024 16:33
@rscohn2 rscohn2 merged commit d88d720 into spack:develop May 24, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-systems core PR affects Spack core functionality intel update-package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants