bison: add missing build dependency

[sethrj]

Building on an "empty" rocky8 image, spack install bison fails because it's missing the texinfo dependency.

/tmp/root/spack-stage/spack-stage-bison-3.8.2-46ttmnqkblgfi4vpdckagxhibiywho5p/spack-src/build-aux/missing: line 81: makeinfo: command not found
WARNING: 'makeinfo' is missing on your system.
         You should only need it if you modified a '.texi' file, or
         any other file indirectly affecting the aspect of the manual.
         You might want to install the Texinfo package:
         <https://www.gnu.org/software/texinfo/>
         The spurious makeinfo call might also be the consequence of
         using a buggy 'make' (AIX, DU, IRIX), in which case you might
         want to install GNU make:
         <https://www.gnu.org/software/make/>
make[2]: *** [Makefile:9582: /tmp/root/spack-stage/spack-stage-bison-3.8.2-46ttmnqkblgfi4vpdckagxhibiywho5p/spack-src/doc/bison.info] Error 127
make[2]: Leaving directory '/tmp/root/spack-stage/spack-stage-bison-3.8.2-46ttmnqkblgfi4vpdckagxhibiywho5p/spack-src/spack-build'
make[1]: *** [Makefile:10377: all-recursive] Error 1
make[1]: Leaving directory '/tmp/root/spack-stage/spack-stage-bison-3.8.2-46ttmnqkblgfi4vpdckagxhibiywho5p/spack-src/spack-build

[spackbot-app]

Hi @sethrj! I noticed that the following package(s) don't yet have maintainers:

• bison

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("sethrj")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame bison

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

[alalazo]

Did you check why we need makeinfo ? Aren't we using a release tarball for bison? (I can also try to check this one later)

[alecbcs]

I'm unable to reproduce the error (bison installs successfully) on a bare rhel8 image when building bison%gcc.
@sethrj are you using a different compiler?

[alecbcs]

Duplicate of #44208

[sethrj]

@alecbcs Sorry, it looks like this is rocky 9, based on the Nvidia distribution: nvidia/cuda:12.4.1-devel-rockylinux9

[sethrj]

see https://github.com/sethrj/celeritas/blob/ci-fix/scripts/docker/dev/Dockerfile and https://github.com/sethrj/celeritas/blob/ci-fix/scripts/docker/dev/rocky-cuda12.yaml .

[haampie]

I couldn't reproduce on ubuntu either. There must be some additional reason...

[haampie]

Ok, the real missing dependency is diffutils.

diff -u /tmp/root/spack-stage/spack-stage-bison-3.8.2-wf5jurn7clwd3m33gzmha6rberf6r6oo/spack-src/doc/cross-options.texi~ /tmp/root/spack-stage/spack-stage-bison-3.8.2-wf5jurn7clwd3m33gzmha6rberf6r6oo/spack-src/doc/cross-options.texi.tmp || true

[alecbcs]

@haampie where are you seeing the dependency on diffutils?

[haampie]

I thought I linked that, but it's used in doc/local.mk.

Hm, on second thought it looks like it's only used to dump to stdout, smth like diff -u a b || true.

Maybe the real issue is some race?

[haampie]

Ok, no, this is the actual issue:

/tmp/root/spack-stage/spack-stage-bison-3.8.2-wf5jurn7clwd3m33gzmha6rberf6r6oo/spack-src/build-aux/move-if-change doc/bison.help.tmp /tmp/root/spack-stage/spack-stage-bison-3.8.2-wf5jurn7clwd3m33gzmha6rberf6r6oo/spack-src/doc/bison.help
/tmp/root/spack-stage/spack-stage-bison-3.8.2-wf5jurn7clwd3m33gzmha6rberf6r6oo/spack-src/build-aux/move-if-change: line 69: cmp: command not found

and cmp is also from diffutils.

[sethrj]

Maybe there are many issues 🙃