Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: add v3.12.2, v3.12.3 #44226

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

s-sajid-ali
Copy link
Contributor

Fixes #43430, Reference: python/cpython#118873

Additionally, do not pass the --with-system-ffi flag from version 3.12.0 per https://github.com/python/cpython/blob/main/Misc/NEWS.d/3.12.0a4.rst

	modified:   var/spack/repos/builtin/packages/python/package.py
Copy link
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. I think we should review also the ctypes variant and related rules in view of the changelog you posted.

@alalazo alalazo self-assigned this May 17, 2024
@s-sajid-ali
Copy link
Contributor Author

s-sajid-ali commented May 17, 2024

Some relevant pointers:

We always require libffi and pkgconfig when using +ctypes when not on windows, which seems to be the only platform where one can build with ~ctypes. Should ctypes only be a variant for windows then? Or can it be turned off for linux/os-x?

@alecbcs alecbcs changed the title python on macos: fix linking with spack built ncurses python: add v3.12.2, v3.12.3 May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python can build with GCC on macOS now
2 participants