Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-matplotlib: add v3.9.0 #44225

Merged
merged 5 commits into from
May 20, 2024
Merged

Conversation

adamjstewart
Copy link
Member

New release of matplotlib that uses meson!

Before

Stage: 0.93s. Install: 31.12s. Post-install: 0.70s. Total: 32.91s

After

Stage: 0.95s. Install: 12.47s. Post-install: 0.65s. Total: 14.58s

alalazo
alalazo previously approved these changes May 17, 2024
@alalazo alalazo self-assigned this May 17, 2024
@alalazo
Copy link
Member

alalazo commented May 17, 2024

@adamjstewart Feel free to merge, if it seems ok to you. Not sure if you're waiting on a review from @rgommers

@adamjstewart
Copy link
Member Author

Hmm, we seem to be building matplotlib 3.8.4 in CI instead. Any idea why?

@rgommers
Copy link
Contributor

I don't see any obvious mistakes in the metadata, all LGTM. Prerequisites of 3.9.0 like meson-python and ninja are built, so no idea why 3.8.4 is selected.

@adamjstewart
Copy link
Member Author

I'm able to reproduce this on the CLI.

> spack spec --fresh py-matplotlib

chooses matplotlib 3.9, but

> spack spec --fresh py-networkx

chooses matplotlib 3.8. Further investigation with spack solve reveals that choosing 3.9 results in more "version badness". This is because we depend on py-ninja instead of ninja, which forces us to use an older version of ninja. I think the easiest solution is to directly depend on ninja.

We've seen a lot of issues with py-cmake in the past. I wonder if we should remove py-cmake and py-ninja and only use the direct dependencies instead.

@alalazo
Copy link
Member

alalazo commented May 18, 2024

I wonder if we should remove py-cmake and py-ninja and only use the direct dependencies instead.

I would be for that. Aren't they pip packaging of the corresponding tool, for convenience of pip users?

@rgommers
Copy link
Contributor

Aren't they pip packaging of the corresponding tool, for convenience of pip users?

Yes they are. Agreed that depending on ninja is better.

@adamjstewart
Copy link
Member Author

#44257

@adamjstewart
Copy link
Member Author

Glad we tested newer matplotlib in CI because it's failing with the OneAPI compilers: https://gitlab.spack.io/spack/spack/-/pipelines/709134. Going to try re-enabling the hacks that were already there for this new version.

@adamjstewart
Copy link
Member Author

@spackbot run pipeline

Copy link

spackbot-app bot commented May 18, 2024

I've started that pipeline for you!

@alalazo alalazo merged commit dcd6b53 into spack:develop May 20, 2024
14 checks passed
@adamjstewart adamjstewart deleted the packages/py-matplotlib branch May 20, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants