-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py-matplotlib: add v3.9.0 #44225
py-matplotlib: add v3.9.0 #44225
Conversation
@adamjstewart Feel free to merge, if it seems ok to you. Not sure if you're waiting on a review from @rgommers |
Hmm, we seem to be building matplotlib 3.8.4 in CI instead. Any idea why? |
I don't see any obvious mistakes in the metadata, all LGTM. Prerequisites of 3.9.0 like |
I'm able to reproduce this on the CLI. > spack spec --fresh py-matplotlib chooses matplotlib 3.9, but > spack spec --fresh py-networkx chooses matplotlib 3.8. Further investigation with We've seen a lot of issues with |
I would be for that. Aren't they pip packaging of the corresponding tool, for convenience of pip users? |
Yes they are. Agreed that depending on |
Glad we tested newer matplotlib in CI because it's failing with the OneAPI compilers: https://gitlab.spack.io/spack/spack/-/pipelines/709134. Going to try re-enabling the hacks that were already there for this new version. |
@spackbot run pipeline |
I've started that pipeline for you! |
New release of matplotlib that uses meson!
Before
Stage: 0.93s. Install: 31.12s. Post-install: 0.70s. Total: 32.91s
After
Stage: 0.95s. Install: 12.47s. Post-install: 0.65s. Total: 14.58s