Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3102: NIRSpec combined MOS/FS processing #8467

Draft
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

melanieclarke
Copy link
Collaborator

@melanieclarke melanieclarke commented May 7, 2024

Resolves JP-3102

Closes #7769

WIP: Process fixed slits defined in MSA metafiles, alongside standard MOS slits.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 51.98238% with 109 lines in your changes are missing coverage. Please review.

Project coverage is 58.90%. Comparing base (4179c09) to head (52359a0).
Report is 6 commits behind head on master.

Files Patch % Lines
jwst/pipeline/calwebb_spec2.py 5.33% 71 Missing ⚠️
jwst/master_background/nirspec_utils.py 50.00% 13 Missing ⚠️
jwst/nsclean/nsclean.py 0.00% 9 Missing ⚠️
jwst/master_background/expand_to_2d.py 63.63% 8 Missing ⚠️
jwst/wavecorr/wavecorr.py 79.31% 6 Missing ⚠️
jwst/combine_1d/combine1d.py 85.71% 1 Missing ⚠️
jwst/pipeline/calwebb_spec3.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8467      +/-   ##
==========================================
+ Coverage   57.97%   58.90%   +0.92%     
==========================================
  Files         387      388       +1     
  Lines       38830    39080     +250     
==========================================
+ Hits        22513    23021     +508     
+ Misses      16317    16059     -258     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment