Set DQ of ref pixels to DO_NOT_USE after refpix correction #7017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdavies-st
force-pushed
the
refpix-posthook-do-not-use
branch
from
4792cc5
to
8dbe419
Compare
Codecov ReportBase: 78.60% // Head: 78.71% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #7017 +/- ##
==========================================
+ Coverage 78.60% 78.71% +0.11%
==========================================
Files 455 455
Lines 39148 39431 +283
==========================================
+ Hits 30771 31039 +268
- Misses 8377 8392 +15
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jdavies-st
force-pushed
the
refpix-posthook-do-not-use
branch
from
8dbe419
to
938a766
Compare
jdavies-st
force-pushed
the
refpix-posthook-do-not-use
branch
from
938a766
to
77e6f86
Compare
jdavies-st
force-pushed
the
refpix-posthook-do-not-use
branch
from
77e6f86
to
21fd546
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7015
This PR addresses the current fragility of how reference pixels are set to DO_NOT_USE in
calwebb_detector1. Currently they rely on the GAIN reference file having zeros in the reference pixel locations, and thenramp_fittingsets those pixels to DO_NOT_USE in the science data DQ.This PR sets the DQ of reference pixels to DO_NOT_USE at the end of the
refpixstep. It does require thatDQInitSteplabel these properly as REFERENCE_PIXELS, but this seems to be the case currently for the currently selected MASK reference files for all instruments.Is this the best way to do this? Thoughts?
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR