Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: Add auto-complete for form fields #509

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bhilbert4
Copy link
Collaborator

This PR adds autocomplete to several of the fields on the webapp forms. This is done using django-autocomplete-lite, which is a new dependency.

At the moment this is work in progress. I've started by trying to apply autocomplete to the proposal search field on the web app's main page.

Other fields that could benefit from autocomplete include several on the EDB page.

@pep8speaks
Copy link

Hello @bhilbert4, Thank you for submitting the Pull Request !

Line 41:1: E402 module level import not at top of file
Line 44:1: E402 module level import not at top of file
Line 45:1: E402 module level import not at top of file
Line 47:1: E402 module level import not at top of file
Line 48:1: E402 module level import not at top of file
Line 49:1: E402 module level import not at top of file
Line 50:1: E402 module level import not at top of file
Line 51:1: E402 module level import not at top of file
Line 52:1: E402 module level import not at top of file
Line 53:1: E402 module level import not at top of file
Line 54:1: E402 module level import not at top of file
Line 55:1: E402 module level import not at top of file
Line 56:1: E402 module level import not at top of file
Line 181:101: E501 line too long (127 > 100 characters)
Line 244:101: E501 line too long (101 > 100 characters)
Line 683:101: E501 line too long (107 > 100 characters)

Line 58:1: E265 block comment should start with '# '
Line 59:1: E265 block comment should start with '# '
Line 69:101: E501 line too long (111 > 100 characters)
Line 96:1: E265 block comment should start with '# '
Line 97:1: E265 block comment should start with '# '
Line 112:5: E265 block comment should start with '# '
Line 115:5: E265 block comment should start with '# '
Line 118:5: E265 block comment should start with '# '

Line 64:101: E501 line too long (102 > 100 characters)
Line 74:101: E501 line too long (104 > 100 characters)
Line 75:101: E501 line too long (103 > 100 characters)
Line 76:101: E501 line too long (112 > 100 characters)
Line 77:101: E501 line too long (110 > 100 characters)
Line 78:101: E501 line too long (136 > 100 characters)
Line 81:101: E501 line too long (119 > 100 characters)
Line 82:101: E501 line too long (151 > 100 characters)
Line 86:101: E501 line too long (121 > 100 characters)
Line 87:101: E501 line too long (129 > 100 characters)
Line 88:101: E501 line too long (150 > 100 characters)
Line 89:101: E501 line too long (138 > 100 characters)
Line 90:101: E501 line too long (120 > 100 characters)
Line 91:101: E501 line too long (135 > 100 characters)
Line 92:101: E501 line too long (127 > 100 characters)
Line 93:101: E501 line too long (116 > 100 characters)
Line 94:101: E501 line too long (131 > 100 characters)
Line 95:101: E501 line too long (119 > 100 characters)

If you have not done so, please consult the jwql Style Guide

@bhilbert4
Copy link
Collaborator Author

Closes #436

@bhilbert4 bhilbert4 self-assigned this Sep 25, 2019
@bhilbert4 bhilbert4 added this to In progress in v0.23 [End of June 2020] via automation Sep 25, 2019
@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #509 (0f0cedf) into develop (0267fe8) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #509      +/-   ##
===========================================
- Coverage    10.66%   10.63%   -0.03%     
===========================================
  Files           57       57              
  Lines         4097     4108      +11     
===========================================
  Hits           437      437              
- Misses        3660     3671      +11     
Impacted Files Coverage Δ
jwql/website/apps/jwql/api_views.py 0.00% <0.00%> (ø)
jwql/website/apps/jwql/data_containers.py 3.29% <0.00%> (-0.04%) ⬇️
jwql/website/apps/jwql/forms.py 0.00% <0.00%> (ø)
jwql/website/apps/jwql/urls.py 0.00% <ø> (ø)
jwql/website/jwql_proj/settings.py 0.00% <ø> (ø)

@bhilbert4
Copy link
Collaborator Author

django-autocomplete-lite tutorial - note that at the very bottom there is some information on performing autocomplete on a list of strings, which is what I think we want to do. The rest of the tutorial is for working on a queryset from a database.

And here is the github test project that kinda-sorta goes with the tutorial

@bourque bourque removed this from In progress in v0.23 [End of June 2020] Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants