Hostname contents and list lengths #1036
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`and` cannot be used to check for two substrings like this. Correctly check for both words in the socket hostname.
|
Hello @snoyes, Thank you for updating !
Comment last updated at 2023-10-02 14:55:07 UTC |
Later code assumes that the list has at least two elements.
snoyes
changed the title
BradleySappington
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the database interface,
andcannot be used to check for two substrings like this code attempts. This code effectively only checks for the word 'project' in the hostname. Correctly check for both words in the socket hostname.In the preview image, the group and integ are allowed to be integers or lists of length 2, but there was no check if the list was of length 0 or 1.